Repository navigation
Clarify docs of set_powerlimits() - #17590
Merged
timhoffm merged 2 commits intoJun 9, 2020
Merged
timhoffm merged 2 commits into
timhoffm merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
timhoffm
force-pushed
the
doc-set_powerlimits
branch
from
bc4af0f to
0423ca6
Compare
June 8, 2020 23:50
This was referenced Jun 8, 2020
tacaswell
force-pushed
the
doc-set_powerlimits
branch
from
0423ca6 to
f5e2f36
Compare
June 9, 2020 18:30
Copy link
Copy Markdown
Member
|
I took the liberty of re-basing to unbreak the doc build and pushed a commit adding a note about the default values. |
Sorry, something went wrong.
tacaswell
approved these changes
Jun 9, 2020
Copy link
Copy Markdown
Member
Author
|
I approve the default values. Since each commit is mutually approved, I can merge 😄. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #15376.
Previous docstring:
This is not correct. In the above terminology one would have to write:
which raises questions on the +1 for min_exp (and was suspected to be a bug in #15376). But actually, I think that's correct and it's better to think of the criterion in terms of the exponent that would be used for scientific notation.