Repository navigation
FIX: be more careful about not importing pyplot early - #17764
Merged
anntzer merged 1 commit intoJun 29, 2020
Merged
anntzer merged 1 commit into
anntzer merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
timhoffm
reviewed
Jun 26, 2020
Comment thread
lib/matplotlib/__init__.py
Outdated
anntzer
reviewed
Jun 26, 2020
Comment thread
lib/matplotlib/__init__.py
Copy link
Copy Markdown
Member
Author
|
Both fair points. |
Sorry, something went wrong.
tacaswell
force-pushed
the
fix_early_use_call
branch
from
a5a1311 to
c9464aa
Compare
June 28, 2020 02:31
In matplotlib.use we import pyplot to use `switch_backend`, however if the user calls `mpl.use(...)` before importing pyplot then during the initial import of pyplot, before we set the selected backend we try to set the backend set via rcParams. This change only imports pyplot if it is already imported, otherwise it is safe to just set the rcParams and not go through the full `plt.switch_backend` path. closes matplotlib#17763
tacaswell
force-pushed
the
fix_early_use_call
branch
from
c9464aa to
b94f5c0
Compare
June 28, 2020 02:33
Copy link
Copy Markdown
Member
Author
|
The test failure was real, it turns out we were relying on the implicit in use to explode when the user asked for an unusable backend. I solved this by a) changing the backend_fallback rcparam in use (which I think we talked about before, but at least I was not sure about. Coming back to this again with a bit of time it seems clear that this is the correct behavior) b) add a pyplot import in the test to get the exception. Hopefully the comments are clear? |
Sorry, something went wrong.
timhoffm
approved these changes
Jun 28, 2020
anntzer
approved these changes
Jun 29, 2020
anntzer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
looks reasonable.
Sorry, something went wrong.
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 29, 2020
timhoffm
added a commit
that referenced
this pull request
Jun 29, 2020
…764-on-v3.3.x Backport PR #17764 on branch v3.3.x (FIX: be more careful about not importing pyplot early)
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
In matplotlib.use we import pyplot to use switch_backend, however
if the user calls mpl.use(...) before importing pyplot then
during the initial import of pyplot, before we set the selected
backend we try to set the backend set via rcParams.
This change only imports pyplot if it is already imported, otherwise
it is safe to just set the rcParams and not go through the full
plt.switch_backend path.
closes #17763
This seems difficult to test given that it is dependent on import order.
PR Checklist