Repository navigation
Special case degree-1 Bezier curves. - #17994
Merged
dopplershift merged 1 commit intoJul 21, 2020
Merged
dopplershift merged 1 commit into
dopplershift merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This greatly speeds up extent computation for the common case of polylines. (We were previously only special-casing the degree-0 case.)
6 tasks
jklymak
approved these changes
Jul 21, 2020
dopplershift
approved these changes
Jul 21, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 5, 2020
QuLogic
added a commit
that referenced
this pull request
Aug 5, 2020
…994-on-v3.3.x Backport PR #17994 on branch v3.3.x (Special case degree-1 Bezier curves.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This greatly speeds up extent computation for the common case of
polylines. (We were previously only special-casing the degree-0 case.)
Partially fixes #17974 (4x speedup locally). My guess is that the real fix will involve restoring a special-case in Path.get_extents for paths that do not contain curves, but this fix is still useful by itself with no additional complexity cost.
PR Summary
PR Checklist