FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support data reference for hexbin() parameter C by timhoffm · Pull Request #18103 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Support data reference for hexbin() parameter C - #18103

Merged
jklymak merged 1 commit into
matplotlib:masterfrom
timhoffm:hexbin-data
Jul 29, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Support data reference for hexbin() parameter C#18103
jklymak merged 1 commit into
matplotlib:masterfrom
timhoffm:hexbin-data

Conversation

timhoffm commented Jul 28, 2020

Copy link
Copy Markdown
Member

PR Summary

Closes #18097.

timhoffm added API: consistency Consistency of the matplotlib API, including naming, behavior, defaults, … New feature labels Jul 28, 2020
timhoffm added this to the v3.4.0 milestone Jul 28, 2020

jklymak commented Jul 28, 2020

Copy link
Copy Markdown
Member

Easy! But hard to tell if it worked - is it OK just to assume the preprocessor works because it works on other functions?

timhoffm commented Jul 29, 2020

Copy link
Copy Markdown
Member Author

I'll answer that with a yes. The preprocessor itself is tested. We don't want to test every variant of possible calls to the plotting functions.

jklymak commented Jul 29, 2020

Copy link
Copy Markdown
Member

Sure, just wanted to make sure it was tested somewhere.

dopplershift approved these changes Jul 29, 2020
View reviewed changes

dopplershift left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

dopplershift commented Jul 29, 2020

Copy link
Copy Markdown
Contributor

Failing tests are:

lib/matplotlib/tests/test_animation.py::test_draw_frame
lib/matplotlib/tests/test_arrow_patches.py::test_fancyarrow[pdf]

They're unrelated and passing here for me on OSX on Python 3.8...so do we ignore or re-run?

jklymak commented Jul 29, 2020

Copy link
Copy Markdown
Member

Those also failed on #18100. So I don't think it is these PRs, though its possible it is a previous PR that has worked its way into master...

jklymak merged commit 97e525c into matplotlib:master Jul 29, 2020
timhoffm deleted the hexbin-data branch July 29, 2020 08:10
QuLogic mentioned this pull request Mar 18, 2021
Merged
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dopplershift dopplershift approved these changes
jklymak jklymak approved these changes

Assignees

No one assigned

Labels

API: consistency Consistency of the matplotlib API, including naming, behavior, defaults, … New feature

Projects

None yet

Milestone

v3.4.0

Development

Successfully merging this pull request may close these issues.

Feature Request: Allow hexbin to use a string for parameter C to refer to column in data (DataFrame)

3 participants

Back | FazBrowse Home | New Git URL