FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Convert _math_style_dict into an Enum. by QuLogic · Pull Request #18555 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Convert _math_style_dict into an Enum. - #18555

Merged
dopplershift merged 1 commit into
matplotlib:masterfrom
QuLogic:mathtext-enum
Sep 25, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Convert _math_style_dict into an Enum.#18555
dopplershift merged 1 commit into
matplotlib:masterfrom
QuLogic:mathtext-enum

Conversation

QuLogic commented Sep 24, 2020

Copy link
Copy Markdown
Member

PR Summary

Instead of a weird dict thing.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

story645 approved these changes Sep 24, 2020
View reviewed changes
Comment thread lib/matplotlib/_mathtext.py
Comment on lines +1951 to 1953
SCRIPTSTYLE = enum.auto()
SCRIPTSCRIPTSTYLE = enum.auto()

story645 Sep 24, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Where are these two used?

QuLogic Sep 24, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hmm, apparently nowhere. My guess is they were defined for compatibility with TeX, but never implemented. Looking at commit messages of #8151, I think that was the author's goal but maybe never got back to it.

jklymak commented Sep 24, 2020

Copy link
Copy Markdown
Member

So we are swapping a weird dict thing for a weird enum thing? 😉 Was there something that motivated this?

QuLogic commented Sep 24, 2020

Copy link
Copy Markdown
Member Author

Modernization, but then I didn't find any other things to convert to enum, so I figured I'd open the PR before it became unmergeable (which is already did once).

But this does mean no typos, because it can be linted, and works with typing, if we ever get around to that.

anntzer commented Sep 24, 2020

Copy link
Copy Markdown
Contributor

I guess (DISPLAYSTYLE, ...) = range(4) (in the Enum definition, not as globals) may be less magical for @jklymak? :) (I slightly prefer it too, it's actually shorter to type...)

jklymak commented Sep 24, 2020

Copy link
Copy Markdown
Member

I mean, I dont' really mind, I just don't see why this is particularly better for something that isn't broken

dopplershift merged commit 5c486d7 into matplotlib:master Sep 25, 2020
QuLogic added this to the v3.4.0 milestone Sep 25, 2020
QuLogic deleted the mathtext-enum branch September 25, 2020 07:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dopplershift dopplershift approved these changes
story645 story645 approved these changes

Assignees

No one assigned

Labels

topic: text/mathtext

Projects

None yet

Milestone

v3.4.0

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL