FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

REORG: add a LineStyle class by brunobeltran · Pull Request #18664 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

REORG: add a LineStyle class - #18664

Closed
brunobeltran wants to merge 3 commits into
matplotlib:mainfrom
brunobeltran:line_style
ConversationCommits (3)ChecksFiles changed
Closed

REORG: add a LineStyle class#18664
brunobeltran wants to merge 3 commits into
matplotlib:mainfrom
brunobeltran:line_style

Conversation

brunobeltran commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

PR Summary

WIP. Goes on top of #18544.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

brunobeltran changed the title Line style REORG: add a LineStyle class Oct 5, 2020
brunobeltran force-pushed the line_style branch 2 times, most recently from 7b454c2 to 843e517 Compare December 14, 2020 21:49
timhoffm mentioned this pull request Jan 2, 2023
Closed
story645 mentioned this pull request Jul 25, 2023
Open

github-actions Bot commented Aug 25, 2023

Copy link
Copy Markdown

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.

github-actions Bot added the status: inactive Marked by the “Stale” Github Action label Aug 25, 2023
story645 mentioned this pull request Aug 22, 2024
Open
greglucas mentioned this pull request Dec 18, 2024
Draft
5 tasks

timhoffm commented Sep 15, 2025

Copy link
Copy Markdown
Member

I don't think we'll go further in the direction of full type classes. See also the discussion in #14642.

timhoffm closed this Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

API: changes Changes to the public API, typically requiring deprecation. Documentation New feature status: inactive Marked by the “Stale” Github Action status: needs rebase status: work in progress topic: rcparams topic: styles

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL