| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
One of the tutorials (I think introductory/usage? don't have time to look right now) uses the glossary. If those like 2 or 3 references get changed to links this will build. As usual will have much more time over the weekend. |
Sorry, something went wrong.
|
Hi @maria-ilie, thanks for taking care of this, and sorry for the terse response earlier. As you can see below, circleci is failing to build the docs, which is because there are secretly references to it hiding in doc/tutorials/introductory/usage.rst, between lines 531--558-ish. The links in this table don't explicitly have the word glossary anywhere, but they don't have to! Since the glossary was the only place where a definition of those references appeared, then at doc build time that's what they were linked to. You can see how this works in the built docs if you want: https://matplotlib.org/tutorials/introductory/usage.html As far as I can tell, this is the only file that uses these links so it would be more appropriate for the references to simply be added at the end of the file, as in the "external hyperlink targets" example here: https://docutils.sourceforge.io/docs/user/rst/quickref.html#external-hyperlink-targets Let me know if you need any more pointers! P.S. I recommend building the docs locally to make sure your changes worked correctly. If the make html command output ends in make: *** [Makefile:33: html] Error 1, then something needs to change for the docs to build correctly (grep for WARNING in the output to find it!) |
Sorry, something went wrong.
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
|
@maria-ilie Thanks and congratulations on your first contribution to Matplotlib. We'd love to see you back! |
Sorry, something went wrong.
|
Thanks @timhoffm and @brunobeltran for your advice and for taking the time to review this pull request! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
Issue #18491 - Removed glossary file and mention of glossary in doc\contents.rst . I checked with grep and there were no other places mentioning glossary.
PR Checklist