| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
I guess this needs a test.... |
Sorry, something went wrong.
|
OK, So I'm not sure about this. This is only triggered by import numpy as np
import matplotlib.pyplot as plt
x = np.arange(10.0)
np.random.seed(1024)
mat = np.random.randn(10, 10)
plt.contour(x, x, mat)
# for a solid colorbar:
cbar = plt.colorbar(location='bottom')
cbar.filled = True
cbar.draw_all()
plt.show()Note that setting filled=True above turns the colorbar solid. However, this is pretty non-standard API, and a pretty strange way to display contours. The user has to manually call draw_all to get this to even happen at all. So I'll suggest this should be merged to cover this strange edge case, but I'm not particularly convinced we want to protect this behaviour with a test. |
Sorry, something went wrong.
|
If you do plt.colorbar(filler=True) instead, you get: issue18595.py:12: MatplotlibDeprecationWarning: The 'filled' parameter to Colorbar has no effect because it is overridden by the mappable; it is deprecated since 3.3 and will be removed two minor releases later. cbar = plt.colorbar(filled=True) so I'm convinced that filled probably should have been deprecated as an accessible attribute. |
Sorry, something went wrong.
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
$ git checkout v3.3.x $ git pull
$ git cherry-pick -m1 d17905cf70600ef3a0123bc869bd9e06b54017de
$ git commit -am 'Backport PR #18860: FIX: stop deprecation message colorbar'
git push YOURFORK v3.3.x:auto-backport-of-pr-18860-on-v3.3.x
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Sorry, something went wrong.
Backport #18860 on branch v3.3.x
| Back | FazBrowse Home | New Git URL |
PR Summary
Closes #18595
This preserves the existing behaviour without a deprecation warning. The existing behaviour is highly questionable, but...
PR Checklist