FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Always pass integers to wx.Size. by QuLogic · Pull Request #19052 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Always pass integers to wx.Size. - #19052

Merged
tacaswell merged 1 commit into
matplotlib:masterfrom
QuLogic:wx-int
Dec 16, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Always pass integers to wx.Size.#19052
tacaswell merged 1 commit into
matplotlib:masterfrom
QuLogic:wx-int

Conversation

QuLogic commented Dec 1, 2020

Copy link
Copy Markdown
Member

PR Summary

Fixes test failure on Python 3.10, https://bugzilla.redhat.com/show_bug.cgi?id=1902382

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

QuLogic added the GUI: wx label Dec 1, 2020
QuLogic added this to the v3.4.0 milestone Dec 1, 2020

tacaswell commented Dec 4, 2020

Copy link
Copy Markdown
Member

Why ceil instead of floor?

anntzer commented Dec 4, 2020

Copy link
Copy Markdown
Contributor

Why ceil instead of floor?

(It would be nice to document once and for all how floating-point canvas sizes (which can legitimately occur e.g. with vector backends) are supposed to be handled by backends that only support integer sizes (typically raster backends).)

QuLogic commented Dec 4, 2020

Copy link
Copy Markdown
Member Author

Because that's what's already done here:

matplotlib/lib/matplotlib/backends/backend_wx.py

Lines 505 to 508 in ff15ca9

FigureCanvasBase.__init__(self, figure)
w, h = map(math.ceil, figure.bbox.size)
# Set preferred window size hint - helps the sizer, if one is connected
wx.Panel.__init__(self, parent, id, size=wx.Size(w, h))

tacaswell merged commit e03d956 into matplotlib:master Dec 16, 2020
QuLogic deleted the wx-int branch December 16, 2020 19:56

QuLogic commented Jan 27, 2021

Copy link
Copy Markdown
Member Author

@meeseeksdev backport to v3.3.x

meeseeksmachine mentioned this pull request Jan 27, 2021
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 27, 2021
Backport PR matplotlib#19052: Always pass integers to wx.Size.
491c957
QuLogic modified the milestones: v3.4.0, v3.3.4 Jan 27, 2021
tacaswell added a commit that referenced this pull request Jan 27, 2021
Merge pull request #19382 from meeseeksmachine/auto-backport-of-pr-19…
db5b330 
…052-on-v3.3.x

Backport PR #19052 on branch v3.3.x (Always pass integers to wx.Size.)
QuLogic mentioned this pull request Jan 29, 2021
Merged
3 tasks done
dependabot Bot mentioned this pull request Mar 8, 2021
Merged
This was referenced Mar 15, 2021
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dopplershift dopplershift approved these changes

Assignees

No one assigned

Labels

GUI: wx

Projects

None yet

Milestone

v3.3.4

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL