FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add the ability to plot striped lines by lucielavigne · Pull Request #19053 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Add the ability to plot striped lines - #19053

Closed
lucielavigne wants to merge 2 commits into
matplotlib:mainfrom
lucielavigne:master
ConversationCommits (2)ChecksFiles changed
Closed

Add the ability to plot striped lines#19053
lucielavigne wants to merge 2 commits into
matplotlib:mainfrom
lucielavigne:master

Conversation

lucielavigne commented Dec 1, 2020 •
edited
Loading

Copy link
Copy Markdown

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

story645 linked an issue Dec 1, 2020 that may be closed by this pull request
Add the ability to plot striped lines #18351
Closed
jklymak changed the title Add the ability to plot striped lines by Arnaud Remy, Lucie Lavigne Add the ability to plot striped lines Dec 2, 2020
jklymak added this to the v3.5.0 milestone Dec 2, 2020

jklymak commented Dec 2, 2020

Copy link
Copy Markdown
Member

Can you add a PR summary or mark as draft if you are not ready for review yet?

timhoffm reviewed Dec 28, 2020
View reviewed changes

timhoffm left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the PR, and welcome to Matplotlib!

Things to do:

  • The comments below.
  • Please fix the formatting issues flake8 complains about.
  • Add a PR summary.

Discussion:
I'm a bit worried that the term offcolor is too vague. Maybe something like dash_gap_color?

Comment thread lib/matplotlib/lines.py
Comment on lines +1069 to +1070
Set the offcolor of the line.
By default set at 'None'

timhoffm Dec 28, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
Set the offcolor of the line.
By default set at 'None'
Set the gap color for the dashed line style.

Comment thread lib/matplotlib/lines.py
Comment on lines +1074 to +1075
offcolor : color or None
"""

timhoffm Dec 28, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
offcolor : color or None
"""
offcolor : color or None
The gap color. If None, the gaps are unfilled.
"""

timhoffm commented Jan 3, 2021

Copy link
Copy Markdown
Member

@lucielavigne do you plan to continue working on this?

jklymak marked this pull request as draft April 23, 2021 16:55
QuLogic modified the milestones: v3.5.0, v3.6.0 Aug 18, 2021
timhoffm modified the milestones: v3.6.0, unassigned Apr 30, 2022
rcomer added a commit to rcomer/matplotlib that referenced this pull request Jun 5, 2022
matplotlib#19053 review actions
72f80a1
rcomer mentioned this pull request Jun 5, 2022
Merged
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

timhoffm timhoffm left review comments

Assignees

No one assigned

Labels

New feature status: needs rebase status: needs revision status: orphaned PR status: superseded

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add the ability to plot striped lines

5 participants

Back | FazBrowse Home | New Git URL