FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support raw/rgba frame format in FFMpegFileWriter by QuLogic · Pull Request #19056 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Support raw/rgba frame format in FFMpegFileWriter - #19056

Merged
anntzer merged 4 commits into
matplotlib:masterfrom
QuLogic:ffmpeg-file-raw
Dec 18, 2020
ConversationCommits (4)ChecksFiles changed
Merged

Support raw/rgba frame format in FFMpegFileWriter#19056
anntzer merged 4 commits into
matplotlib:masterfrom
QuLogic:ffmpeg-file-raw

Conversation

QuLogic commented Dec 2, 2020

Copy link
Copy Markdown
Member

PR Summary

This could maybe be tested, but I think maybe after the cleanup from #19044.

Additionally, copy the logging setting that is done in FFMpegWriter._args.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

QuLogic added this to the v3.4.0 milestone Dec 2, 2020
QuLogic mentioned this pull request Dec 2, 2020
Merged
7 tasks
Copy logging setup from FFMpegWriter to FFMpegFileWriter.
755fc9e
Support raw/rgba frame format in FFMpegFileWriter.
97a2b36
Remove unsupported animation frame formats.
8922733 
Since `supported_formats` determines the valid `frame_format` values,
and the latter is passed to `Figure.savefig`, the former must be a
subset of the file formats to which Matplotlib supports saving things.
TST: Check all supported animation frame formats.
6e3864a

QuLogic commented Dec 16, 2020

Copy link
Copy Markdown
Member Author

I added testing, and also found that some listed formats are not actually supported, so removed those.

anntzer merged commit ecba1d2 into matplotlib:master Dec 18, 2020
QuLogic deleted the ffmpeg-file-raw branch December 18, 2020 22:12
QuLogic mentioned this pull request Mar 18, 2021
Merged
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dopplershift dopplershift approved these changes
anntzer anntzer approved these changes

Assignees

No one assigned

Labels

third-party integration topic: animation

Projects

None yet

Milestone

v3.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL