FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Hatching "style" class for GSOD by brunobeltran · Pull Request #19077 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Hatching "style" class for GSOD - #19077

Closed
brunobeltran wants to merge 8 commits into
matplotlib:mainfrom
brunobeltran:hatch
ConversationCommits (8)ChecksFiles changed
Closed

Hatching "style" class for GSOD#19077
brunobeltran wants to merge 8 commits into
matplotlib:mainfrom
brunobeltran:hatch

Conversation

brunobeltran commented Dec 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

Goes on top of #18544.

Besides the documentation changes, this now exposes the "density" kwarg to the user, and deprecated non-integer values of "density".

WIP. Only here to document partial completion for GSOD.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

jklymak commented Dec 10, 2020

Copy link
Copy Markdown
Member

@brunobeltran its pretty hard to comment on this with so little info above, and so much extraneous info in the commit. What are we supposed to look at?

Of the top of my head I don't know why the density argument would need to be an integer...

story645 mentioned this pull request Jul 25, 2023
Open

github-actions Bot commented Sep 18, 2023

Copy link
Copy Markdown

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.

github-actions Bot added the status: inactive Marked by the “Stale” Github Action label Sep 18, 2023
story645 added keep Items to be ignored by the “Stale” Github Action and removed status: inactive Marked by the “Stale” Github Action labels Sep 18, 2023

timhoffm commented Sep 15, 2025

Copy link
Copy Markdown
Member

We are not going to systematically introduce full type classes. See also #14642.

timhoffm closed this Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

keep Items to be ignored by the “Stale” Github Action status: needs rebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL