Repository navigation
Fix headless tests on Wayland. - #19083
Merged
tacaswell merged 1 commit intoDec 16, 2020
Merged
tacaswell merged 1 commit into
tacaswell merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
anntzer
reviewed
Dec 9, 2020
Comment thread
lib/matplotlib/tests/test_backends_interactive.py
Outdated
QuLogic
force-pushed
the
headless-tests
branch
2 times, most recently
from
2bfba7c to
ed6c62d
Compare
December 9, 2020 21:52
Since matplotlib#17396, backends now check for Wayland settings as part of headless detection. However, the headless tests do not override those settings. When running on Wayland, they thus think the display exists when they are not supposed to.
QuLogic
force-pushed
the
headless-tests
branch
from
ed6c62d to
a4087b0
Compare
December 10, 2020 00:10
timhoffm
approved these changes
Dec 11, 2020
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Since #17396, backends now check for Wayland settings as part of headless detection. However, the headless tests do not override those settings. When running on Wayland, they thus think the display exists when they are not supposed to.
PR Checklist