Repository navigation
Use Qt events to refresh pixel ratio. - #19123
Merged
jklymak merged 1 commit intoDec 18, 2020
Merged
jklymak merged 1 commit into
jklymak merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
anntzer
reviewed
Dec 16, 2020
Comment thread
lib/matplotlib/backends/backend_qt5.py
Outdated
6 tasks done
With this, we don't need to check things on every draw, but can instead rely on Qt telling us to update DPI.
QuLogic
force-pushed
the
qt-screen-change
branch
from
d9f57b7 to
7bc17ad
Compare
December 16, 2020 09:41
dopplershift
approved these changes
Dec 16, 2020
jklymak
approved these changes
Dec 17, 2020
jklymak
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This didn't break anything for me - does anyone have a multi-dpi setup we could test on?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I tested this on Windows with a Miracast second display; I was not able to test directly on Linux due to HDMI cabling issues, but was able to check in a nested mutter server with multiple displays. |
Sorry, something went wrong.
This was referenced Dec 18, 2020
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
With this, we don't need to check things on every draw, but can instead rely on Qt telling us to update DPI.
This also fixes the pixel ratio test, which has never really worked for me. Hopefully it is not broken elsewhere.
PR Checklist