FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Deprecate @cbook.deprecated and move internal calls to @_api.deprecated by timhoffm · Pull Request #19151 · matplotlib/matplotlib · GitHub

Repository navigation

Deprecate @cbook.deprecated and move internal calls to @_api.deprecated - #19151

Merged
dopplershift merged 1 commit into
matplotlib:masterfrom
timhoffm:change-deprecated-usage
Dec 24, 2020
Merged

dopplershift merged 1 commit into
matplotlib:masterfrom
timhoffm:change-deprecated-usage

Conversation

Copy link
Copy Markdown
Member

PR Summary

Followup of moving all API helpers to matplotlib._api (#18657).

timhoffm added this to the v3.3.4 milestone Dec 18, 2020
timhoffm force-pushed the change-deprecated-usage branch from bf99c22 to 93ac48f Compare December 18, 2020 22:29
Comment thread lib/matplotlib/backends/qt_compat.py Outdated
timhoffm force-pushed the change-deprecated-usage branch 2 times, most recently from 8edda00 to 685c002 Compare December 20, 2020 16:41

QuLogic commented Dec 21, 2020

Copy link
Copy Markdown
Member

Test failures are relevant.

QuLogic modified the milestones: v3.3.4, v3.4.0 Dec 21, 2020
timhoffm force-pushed the change-deprecated-usage branch from 685c002 to ba92d08 Compare December 22, 2020 00:50

Copy link
Copy Markdown
Member Author

Doc builds fail because of

<unknown>:1: WARNING: py:class reference target not found: mpl_toolkits.axisartist.axisline_style._FancyAxislineStyle.FilledArrow
<unknown>:1: WARNING: py:class reference target not found: mpl_toolkits.axisartist.axisline_style._FancyAxislineStyle.SimpleArrow

Has anybody an idea where that comes from and how to fix it?

QuLogic commented Dec 22, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Going to ignore the doc failure, as it's not relevant to this PR. Oops, only one approval so scratch that; see #19163 for the doc fix.

timhoffm force-pushed the change-deprecated-usage branch from ba92d08 to fa71a21 Compare December 22, 2020 10:20

Copy link
Copy Markdown
Member Author

Rebased to include #19163.

dopplershift merged commit 99e6240 into matplotlib:master Dec 24, 2020
timhoffm deleted the change-deprecated-usage branch December 24, 2020 13:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL