| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
I’d much rather have the tests. 72kb doesn’t seem worth worrying about.
Sorry, something went wrong.
|
Actually one possibility would be to only test in svg and using rcParams["svg.fonttype"] = "none", which avoids embedding the font, and therefore results in a very small (1.7kb) file. (Another 30% could be chopped off if you could get rid of the metadata block...) In order to render the result correctly, inkscape needs to know the path to Matplotlib fonts. This can either be done by adding "Additional font directories" in the Inkscape GUI under preferences/tools/text, or (I guess that'll be the practical solution for us, which should be reasonably easily automatable) by copying the Matplotlib fonts to e.g. /tmp/foo/inkscape/fonts and running inkscape with XDG_CONFIG_HOME=/tmp/foo. I think the savings may be worth it? Especially as this should allow us to work much more regularly on adding mathtext improvements without being restricted by the baseline images problem at all. |
Sorry, something went wrong.
|
Can we not merge the new tests with the old ones? |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
Fixes #8665 by using the code snippet proposed there #8665 (comment).
The test images show that it works.
I'm a bit hesitant to add 72kB of images just for testing this. I would also be ok to strip the test again and commit without tests. It's rather unlikely that we'll touch the base part of sqrt again and break it.