Repository navigation
Fixed polygon3d rendering bug issue #178 - #1928
ianthomas23 wants to merge 1 commit into
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
This changes the API of this function. The correct way to go about this is to deprecate this one and have a new function set up to replace it. Or, have a kwarg defaulting to False to indicate whether to return the codes as well.
Sorry, something went wrong.
There was a problem hiding this comment.
@WeatherGod: I have changed all code that calls this and the other function you have highlighted. I see these as internal (i.e. private) functions, even though they are do not have leading underscores.
Sorry, something went wrong.
There was a problem hiding this comment.
They are not private. These are public methods to objects that people do manipulate in the wild. You will have to go through the proper process for this change.
Sorry, something went wrong.
This is a candidate fix for the mplot3d polygon rendering bug of issue #178; it will also allow PR #1299 to proceed.
The changes are all in the mplot3d code, except for one new function in collections.py which is only called from mplot3d code. With this fix the test script added by @WeatherGod to #178 works OK, and all the existing mplot3d examples work as before.
The code changes are not elegant, but are consistent with existing mplot3d code.
I haven't PEP8'd the changes as the original mplot3d files haven't been PEP8'd yet.