Repository navigation
Add kerning to single-byte strings in PDFs - #19582
Merged
QuLogic merged 2 commits intoMar 4, 2021
Merged
QuLogic merged 2 commits into
QuLogic merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks for this! This changes 10 PDF tests, so those images will have to be updated. There is also a flake8 error. |
Sorry, something went wrong.
sauerburger
force-pushed
the
pdf-ascii-string-kerning
branch
2 times, most recently
from
b30d609 to
08f03c1
Compare
March 1, 2021 16:06
Copy link
Copy Markdown
Member
Author
|
The failing PDF tests were actually a string encoding issue on my side. I've fixed this now, and improved the code style. |
Sorry, something went wrong.
anntzer
reviewed
Mar 1, 2021
Comment thread
lib/matplotlib/tests/test_text.py
Outdated
anntzer
reviewed
Mar 1, 2021
Comment thread
lib/matplotlib/backends/backend_pdf.py
Outdated
sauerburger
force-pushed
the
pdf-ascii-string-kerning
branch
from
08f03c1 to
f179cce
Compare
March 1, 2021 17:25
anntzer
reviewed
Mar 1, 2021
Comment thread
lib/matplotlib/backends/backend_pdf.py
anntzer
approved these changes
Mar 1, 2021
sauerburger
force-pushed
the
pdf-ascii-string-kerning
branch
from
f179cce to
b555611
Compare
March 1, 2021 19:42
Copy link
Copy Markdown
Member
|
Don't forget to mark this ready for review. |
Sorry, something went wrong.
sauerburger
marked this pull request as ready for review
March 2, 2021 08:27
aitikgupta
reviewed
Mar 2, 2021
Comment thread
lib/matplotlib/backends/backend_pdf.py
Outdated
QuLogic
reviewed
Mar 3, 2021
Comment thread
lib/matplotlib/tests/test_text.py
Outdated
tacaswell
previously requested changes
Mar 3, 2021
sauerburger
force-pushed
the
pdf-ascii-string-kerning
branch
from
b555611 to
4881758
Compare
March 3, 2021 21:39
sauerburger
force-pushed
the
pdf-ascii-string-kerning
branch
from
4881758 to
1251563
Compare
March 3, 2021 22:22
QuLogic
approved these changes
Mar 4, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 4, 2021
tacaswell
added a commit
that referenced
this pull request
Mar 4, 2021
…582-on-v3.4.x Backport PR #19582 on branch v3.4.x (Add kerning to single-byte strings in PDFs)
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR #18517 adds kerning to strings in PDFs if the string contains multi-byte chars. In case of strings consisting only of single-byte chars, the PDF output does not contains kerning (PDF operator Tj). This PR adds kerning to the single-byte case and adds the string using the TJ operator. See also #19581.
PR Checklist