| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
We can close #19602 if simpler, though suggest stealing some of the commentary. Also suggest the softlink so no one complains... |
Sorry, something went wrong.
More detail:Previously matplotlibrc.template was changed in #15029 to be the canonical place to get the defaults for all the rcParams. However, these were read during __init__.py from lib/matplotlib/mpl-data/matplotlibrc. lib/matplotlib/mpl-data/matplotlibrc doesn't exist in the repo, and only gets created when setup.py is called. We can't read the defaults from matplotlbrc.template because that file probably doesn't exist in most user installs. Aside from being somewhat rickety, the problem is that developers working from an editable install don't want to always call setup.py as it requires compiling the C extensions, and hence their lib/matplotlib/mpl-data/matplotlibrc can get out of sync with the library. The solution here is to simply make lib/matplotlib/mpl-data/matplotlibrc the canonical source of the defaults, add it to version control, (maybe softlink it to matplotlib.template). setup.py can change lib/matplotlib/mpl-data/matplotlibrc in-place See also: |
Sorry, something went wrong.
There was a problem hiding this comment.
This seems fine to me, though I do not fully grok the setup.py changes.
Sorry, something went wrong.
There was a problem hiding this comment.
modulo making sure it is a no-op in the default case.
Sorry, something went wrong.
|
added a test checking the default backend. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
See #19588, #19602.
PR Checklist