FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix default backend by tacaswell · Pull Request #19854 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Fix default backend - #19854

Closed
tacaswell wants to merge 2 commits into
matplotlib:masterfrom
tacaswell:fix_default_backend
ConversationCommits (2)ChecksFiles changed
Closed

Fix default backend#19854
tacaswell wants to merge 2 commits into
matplotlib:masterfrom
tacaswell:fix_default_backend

Conversation

tacaswell commented Apr 2, 2021

Copy link
Copy Markdown
Member

PR Summary

  • makes the source installed and real-install matplotlibrc identical
  • be forgiving of empty backend value and treat the same as no backend entry.

PR Checklist

  • Has pytest style unit tests (and pytest passes). (this is an import bug)
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).

tacaswell added 2 commits April 2, 2021 16:53
MNT: make the source installed backend default and installed match
01f4b57 
There is logic in setup.py to either set the value to a build-time
config (so packagers can be opinionated about the default) or empty
to get the fallback default.

When working on a source-install this logic is not run.
FIX: ignore empty backend value in matplotlibrc
7264112 
See comment in code.  Accounts for the fact that we can to directly specify the
"fallback" backend value.  This interprets the lack of a backend entry and an
empty backend entry the same.

closes matplotlib#19848
tacaswell added this to the v3.5.0 milestone Apr 2, 2021
tacaswell mentioned this pull request Apr 2, 2021
Closed

anntzer commented Apr 2, 2021

Copy link
Copy Markdown
Contributor

Actually I had a different fix coming in soon.
The problem of the current approach (not this PR, just the current status) is that the ability of third-party packagers to put in a different default backend (via setup.cfg) has been lost, because we always default to auto_backend_sentinel, rather than respecting the entry in mpl-data/matplotlibrc if the packager set it. I'm not actually convinced that packagers need to be able to set a different default backend (again, I'd rather "matplotlib" to always mean the same thing, not customized versions), but some may care...

ianhi commented Apr 2, 2021

Copy link
Copy Markdown
Contributor

Happened to be online so giving it a go here: mpl-extensions/mpl-interactions#178 as a real world test

In particular this run: https://github.com/ianhi/mpl-interactions/pull/178/checks?check_run_id=2256624853

so this definitely fixes the pytest-mpl error.

anntzer mentioned this pull request Apr 2, 2021
Merged
7 tasks
tacaswell modified the milestones: v3.5.0, unassigned Apr 2, 2021
tacaswell closed this Apr 2, 2021
tacaswell deleted the fix_default_backend branch April 2, 2021 22:35

tacaswell commented Apr 2, 2021

Copy link
Copy Markdown
Member Author

Closing in favor of #19855

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL