FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support SubFigures in AxesDivider. by anntzer · Pull Request #20073 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Support SubFigures in AxesDivider. - #20073

Merged
QuLogic merged 1 commit into
matplotlib:masterfrom
anntzer:adsf
May 13, 2021
ConversationCommits (1)ChecksFiles changed
Merged

Support SubFigures in AxesDivider.#20073
QuLogic merged 1 commit into
matplotlib:masterfrom
anntzer:adsf

Conversation

anntzer commented Apr 25, 2021

Copy link
Copy Markdown
Contributor

PR Summary

Closes #20069 (comment).

Goes on top of #20069 and #20072. The example now gives

Writing a test specifically for this case is currently left as an exercise to the reader...

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

anntzer mentioned this pull request Apr 25, 2021
Merged
7 tasks
anntzer force-pushed the adsf branch 3 times, most recently from e773520 to 09115c3 Compare April 25, 2021 15:52

jklymak commented Apr 25, 2021

Copy link
Copy Markdown
Member

The example doesn't seem to work? https://57378-1385122-gh.circle-artifacts.com/0/doc/build/html/gallery/axes_grid1/simple_axes_divider1.html#sphx-glr-gallery-axes-grid1-simple-axes-divider1-py

anntzer commented Apr 25, 2021

Copy link
Copy Markdown
Contributor Author

That's just s-g and subfigures not playing well together; I guess here I just needed to have a single block from the pov of s-g so that it shows the whole figure at the end.

jklymak commented Apr 25, 2021

Copy link
Copy Markdown
Member

Looks good. But I looked at this for a few minutes, and still can't guess how that code makes a 2x2 grid, or what nx, ny etc are. Since you must understand it at this point, can you add a few more comments explaining it?

anntzer commented Apr 25, 2021

Copy link
Copy Markdown
Contributor Author

Does https://57381-1385122-gh.circle-artifacts.com/0/doc/build/html/tutorials/toolkits/axes_grid.html#axesdivider help a bit? (I think I'd rather get the tutorial clear and not try to explain the same thing in multiple places)

jklymak commented Apr 25, 2021

Copy link
Copy Markdown
Member

... sure, but maybe link the tutorial here?

anntzer force-pushed the adsf branch 2 times, most recently from 43402a2 to 3362976 Compare April 26, 2021 09:17

anntzer commented Apr 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Sure.
Also rebased to remove the dependency on #20069, so this can go in as is.

anntzer force-pushed the adsf branch 2 times, most recently from 7969538 to 3b727b6 Compare April 26, 2021 09:20

anntzer commented May 6, 2021

Copy link
Copy Markdown
Contributor Author

rebased

QuLogic merged commit 4c5eff9 into matplotlib:master May 13, 2021
anntzer deleted the adsf branch May 13, 2021 09:22
tacaswell added this to the v3.5.0 milestone May 14, 2021
timhoffm mentioned this pull request Jul 6, 2021
Merged
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

QuLogic QuLogic approved these changes
jklymak jklymak approved these changes

Assignees

No one assigned

Labels

topic: mpl_toolkit

Projects

None yet

Milestone

v3.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL