FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Wrong text baseline with usetex. by mdboom · Pull Request #2015 · matplotlib/matplotlib · GitHub

Repository navigation

Wrong text baseline with usetex. - #2015

Merged
mdboom merged 2 commits into
matplotlib:masterfrom
mdboom:usetex-baseline-fixes
May 16, 2013
Merged

mdboom merged 2 commits into
matplotlib:masterfrom
mdboom:usetex-baseline-fixes

Conversation

mdboom commented May 15, 2013

Copy link
Copy Markdown
Member

With current master, examples/pylab_examples/usetex_baseline_test.py produces the following image. And the baseline is wrong when usetex is used.

It used to work fine and it still does in v1.2.x.

http://matplotlib.org/examples/pylab_examples/usetex_baseline_test.html

Any clue what changed this?

mdboom commented May 15, 2013

Copy link
Copy Markdown
Member

Probably #1810, which changed how baselines are handled. I'll look into it.

ghost assigned mdboom May 15, 2013
… baseline handling was broken for text.usetex = True. This brings it inline with everything else (where the assumption is that y == 0 is the baseline and not the bottom).

mdboom commented May 15, 2013

Copy link
Copy Markdown
Member

@leejjoon: I think this should do it.

[Background: #1810 changed things so the backends were passed the location of the baseline, rather than the bottom, of the text for draw_text. This is much more natural for most backends (other than Agg) and simplified a number of things. This just brings the draw_tex methods inline with that.]

Copy link
Copy Markdown
Contributor Author

Thanks! This fixes the problem.

mdboom added a commit that referenced this pull request May 16, 2013
mdboom merged commit 4ed18ca into matplotlib:master May 16, 2013
mdboom deleted the usetex-baseline-fixes branch August 7, 2014 13:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL