FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improve fancyarrow_demo. by anntzer · Pull Request #20430 · matplotlib/matplotlib · GitHub

Repository navigation

Improve fancyarrow_demo. - #20430

Merged
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:fad
Jun 13, 2021
Merged

timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:fad

Conversation

anntzer commented Jun 13, 2021

Copy link
Copy Markdown
Contributor

Don't alphabetically sort the arrowstyles; the order of definition in
the source makes more sense. (The sorted call was necessary back when
dicts were unsorted.) Also move the definition of BracketAB after
BracketA and BracketB, for consistency with the other arrow styles.

Various small fixes (making the axis invisible is already done by
frameon=False, no need to use mathtext).

before:

after:

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Don't alphabetically sort the arrowstyles; the order of definition in
the source makes more sense.  (The `sorted` call was necessary back when
dicts were unsorted.)  Also move the definition of BracketAB after
BracketA and BracketB, for consistency with the other arrow styles.

Various small fixes (making the axis invisible is already done by
frameon=False, no need to use mathtext).
timhoffm added this to the v3.5.0 milestone Jun 13, 2021
timhoffm merged commit cf1824f into matplotlib:master Jun 13, 2021
anntzer deleted the fad branch June 13, 2021 19:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL