| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
This looks good. I'm surprised that there ins't a built in sphinx option for this though.... |
Sorry, something went wrong.
|
Sorry for the delay, was caught up with the non-digital world. I have addressed the comments by @QuLogic. I think now it should be fine hopefully, otherwise I can make changes np. @jklymak |
Sorry, something went wrong.
|
Many of these links don't seem to go to the right place, though some of them do... |
Sorry, something went wrong.
|
Are these the ones that are deprecated? While I tested it, I saw those would go to the deprecation github page. Aside from that, also add_callback confuses the function with the docstring add_callback. Any other ones? In that case, I think its the inspect functions themselves, but yeah not sure. |
Sorry, something went wrong.
|
I only did a spot check, but starting from https://62590-1385122-gh.circle-artifacts.com/0/doc/build/html/api/axes_api.html barh works, but bar does not. fill_between and fill_betweenx do not work, for me at least (Safari). i.e. fill_between links to: https://github.com/matplotlib/matplotlib/blob/300e9cdb/lib/matplotlib/__init__.py#L5259-L5263 |
Sorry, something went wrong.
|
So now those ones you spotted are fixed. I also checked around ~20 more of those, and they look ok as well. Edit: lib/mpl_toolkits links were not generated, now it is. I guess 3rd time the charm? |
Sorry, something went wrong.
|
Great. Do you know why they were different? |
Sorry, something went wrong.
|
I noticed inspect.getsourcefile(obj) was returning the filename to be lib/matplotlib/__init__.py instead of the python file name in which it was defined. Thus, I added fn.endswith('__init__.py') to get the filename like shown below and then it shows the proper filename. if not fn or fn.endswith('__init__.py'):
fn = inspect.getsourcefile(sys.modules[obj.__module__]) |
Sorry, something went wrong.
|
@QuLogic I added some extra Exceptions and added the rest of your suggestions. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
Addresses #20557 to point the [SOURCE] in docs point to github instead. A proper build config to build the old way is still missing, but perhaps that can be part of separate PR. Also, this impl was copied from scipy conf.py, but modified slightly to work here instead.
PS: Building old way is just adding back the sphinx.ext.viewcode, but I was not sure how to add it as part of a make O=-Dmyarg=1 html.
PR Checklist