| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
AFAICT `mouseDown()` and friends already check `[event type]` and correctly handle right/middle button events, so the other event handlers can just defer to them. The point of the deduplication is so that future event rearchitecting doesn't have to repeat loads of keyboard-modifiers handling code in each of these handlers.
There was a problem hiding this comment.
Interactive zoom-out works on my Macbook Pro (I don't have a right mouse button but dragging with two fingers is equivalent).
Sorry, something went wrong.
There was a problem hiding this comment.
This also worked for me on macos. I had a right button that zoomed out as expected.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
AFAICT mouseDown() and friends already check [event type] and
correctly handle right/middle button events, so the other event handlers
can just defer to them.
The point of the deduplication is so that future event rearchitecting
(subsequent to #16931 and fixing #6159)
doesn't have to repeat loads of keyboard-modifiers handling code in each
of these handlers.
I don't actually have a mac to test this :-) so it would be nice if
someone could check if e.g. interactive zoom-out (by drawing a rubberband
with a right click) still works fine.
PR Summary
PR Checklist