| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
I'm a little confused about marking this as experimental? Isn't this the only way to manage the colormap registry? Or is your point that the access methods etc are experimental, but the old API still exists? |
Sorry, something went wrong.
|
Yes, the old API still exists. On the dev call we decided to be on the safe side and mark the new API as experimental to still have the freedom to change everything. Dee also the transition path in #20853. |
Sorry, something went wrong.
|
subplots_mosaic is tagged provisional(https://matplotlib.org/devdocs/tutorials/index.html#provisional) so should there be some sort of consistency? |
Sorry, something went wrong.
|
I was following th "experimental" terminology from scipy. Also to me, "provisional" sounds unfinished and not in the final state. Indeed:
https://dictionary.cambridge.org/dictionary/english/provisional It's unlikely but possible that the ColormapRegistry changes, so provisional is not the right term. |
Sorry, something went wrong.
|
So then should the section of the tutorials subplot mosaic is in change to experimental? Either word indicates that the API isn't final? |
Sorry, something went wrong.
|
I think so. Both indicate not final, but in my understanging "provisional" = likely to change; "experimental" = might still change. But that should be re-checked by native speakers. |
Sorry, something went wrong.
|
We have been using "experimental" for years now, so should probably stick to that? |
Sorry, something went wrong.
|
We have been using both, but more often "experimental": experimental: 36 hits provisional: 10 hits |
Sorry, something went wrong.
|
|
||
|
|
||
| def colormaps(): | ||
| """ |
There was a problem hiding this comment.
Should this docstring be copied (with slight editing) into ColormapRegistry.__doc__, e.g. into a Notes section (so that it is still available e.g. under ipython with plt.colormaps?)?
Sorry, something went wrong.
There was a problem hiding this comment.
I don't think so. The old docstring is a bit tutorial plus a long description of all available colormaps. This is essentially all covered in the colormap reference and the colormap tutorials. The docstring of ColormapRegistry should essentially be limited to the API.
Sorry, something went wrong.
There was a problem hiding this comment.
I guess the question is, do we want to have a description of all colormaps available "offline" from just standard docstrings. But perhaps that would be better served by having some colormap metadata anyways... so that discussion can happen later.
Sorry, something went wrong.
|
@dstansby I've clarified what experimental means here. |
Sorry, something went wrong.
…nd add it to pyplot
…935-on-v3.5.x Backport PR #20935 on branch v3.5.x (Add ColormapsRegistry as experimental and add it to pyplot)
ENH: Add ColormapsRegistry as experimental and add it to pyplot
ENH: Add ColormapsRegistry as experimental and add it to pyplot
| Back | FazBrowse Home | New Git URL |
PR Summary
Follow-up to #18503.
See also #20853.