FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make warning for no-handles legend more explicit. by anntzer · Pull Request #20956 · matplotlib/matplotlib · GitHub

Repository navigation

Make warning for no-handles legend more explicit. - #20956

Merged
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:lhu
Sep 1, 2021
Merged

timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:lhu

Conversation

anntzer commented Aug 31, 2021

Copy link
Copy Markdown
Contributor

It may be slightly better to only emit the longer message if there were
actually handles that got ignored because of the leading underscore, but
that's actually a bit annoying to check (or requires some refactoring of
_get_legend_handles_labels).

See #5200 (comment).

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

It may be slightly better to only emit the longer message if there were
actually handles that got ignored because of the leading underscore, but
that's actually a bit annoying to check (or requires some refactoring of
_get_legend_handles_labels).
QuLogic added this to the v3.5.0 milestone Aug 31, 2021
timhoffm merged commit ceb794c into matplotlib:master Sep 1, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 1, 2021
QuLogic added a commit that referenced this pull request Sep 1, 2021
…956-on-v3.5.x

Backport PR #20956 on branch v3.5.x (Make warning for no-handles legend more explicit.)
anntzer deleted the lhu branch September 1, 2021 06:20
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
Make warning for no-handles legend more explicit.
ericpre pushed a commit to ericpre/matplotlib that referenced this pull request Oct 20, 2021
Make warning for no-handles legend more explicit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL