Repository navigation
Fix hexbin marginals and log scaling - #21039
Merged
jklymak merged 2 commits intoSep 24, 2021
Merged
jklymak merged 2 commits into
jklymak merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
7 tasks
anntzer
approved these changes
Sep 20, 2021
jklymak
reviewed
Sep 20, 2021
Comment thread
lib/matplotlib/tests/test_axes.py
| fig, ax = plt.subplots() | ||
| h = ax.hexbin(x, y, yscale='log', bins='log') | ||
| h = ax.hexbin(x, y, yscale='log', bins='log', | ||
| marginals=True, reduce_C_function=np.sum) |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
looks like there is no linear scale marginals=True? Can we add that test?
Sorry, something went wrong.
jklymak
approved these changes
Sep 24, 2021
jklymak
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think this should be in 3.5 so lets merge. My request for a test can be dealt with later...
Sorry, something went wrong.
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 24, 2021
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 12, 2021
Fix `hexbin` marginals and log scaling
tacaswell
pushed a commit
that referenced
this pull request
Oct 20, 2021
Fix `hexbin` marginals and log scaling
1 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This cleans up and fixes hexbin marginals. In particular:
Also don't add 1 to log-scaled bins (originally in #21038).
Current master:
With this PR:
PR Checklist