FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add GHA testing whether files were added and deleted in the same PR. by anntzer · Pull Request #21359 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Add GHA testing whether files were added and deleted in the same PR. - #21359

Merged
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:cleanpr
Oct 15, 2021
ConversationCommits (1)ChecksFiles changed
Merged

Add GHA testing whether files were added and deleted in the same PR.#21359
timhoffm merged 1 commit into
matplotlib:masterfrom
anntzer:cleanpr

Conversation

anntzer commented Oct 14, 2021

Copy link
Copy Markdown
Contributor

PR Summary

Currently has two extra commits that test the functionality and should fail the workflow. Will remove these commits once we know this works.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

anntzer force-pushed the cleanpr branch 9 times, most recently from 940ffb9 to cdc9e73 Compare October 14, 2021 21:21
timhoffm approved these changes Oct 14, 2021
View reviewed changes

timhoffm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Optional: Can we make the message stand out more? It's a bit burried between the other output:

Maybe add ------------ lines above and below? Or do you have a better idea?

anntzer commented Oct 14, 2021

Copy link
Copy Markdown
Contributor Author

I removed the other output.
I don't think it's worth overengineering this, as we don't expect this to fail so often :-) But if you have a better solution, feel free to push it.

QuLogic commented Oct 14, 2021

Copy link
Copy Markdown
Member

You can print out a special message which executes a workflow command, creating an annotation. I'm not sure how it looks if the annotation is on a file that is subsequently deleted.

anntzer commented Oct 14, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I'm not sure I really want to try (and loop over lines in bash, which I never remember how to do :-)), but you should feel free to do so :-)

jklymak approved these changes Oct 15, 2021
View reviewed changes

jklymak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks helpful!

timhoffm commented Oct 15, 2021

Copy link
Copy Markdown
Member

@anntzer this is ready. Please remove the test commits.

anntzer commented Oct 15, 2021

Copy link
Copy Markdown
Contributor Author

Done.

timhoffm merged commit 5a99a60 into matplotlib:master Oct 15, 2021

timhoffm commented Oct 15, 2021

Copy link
Copy Markdown
Member

@meeseeksdev backport to v3.5.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 15, 2021
Backport PR matplotlib#21359: Add GHA testing whether files were adde…
a1c33dd 
…d and deleted in the same PR.
meeseeksmachine mentioned this pull request Oct 15, 2021
Merged
timhoffm added this to the v3.5.0 milestone Oct 15, 2021
jklymak added a commit that referenced this pull request Oct 15, 2021
Merge pull request #21367 from meeseeksmachine/auto-backport-of-pr-21…
aed0ec6 
…359-on-v3.5.x

Backport PR #21359 on branch v3.5.x (Add GHA testing whether files were added and deleted in the same PR.)
anntzer deleted the cleanpr branch October 15, 2021 11:16
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
Merge pull request #21359 from anntzer/cleanpr
704b855 
Add GHA testing whether files were added and deleted in the same PR.
anntzer mentioned this pull request Nov 10, 2021
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jklymak jklymak approved these changes
timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL