FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Enable tests for text path based markers by deep-jkl · Pull Request #21377 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Enable tests for text path based markers - #21377

Merged
QuLogic merged 1 commit into
matplotlib:masterfrom
deep-jkl:enable_text_marker_tests
Oct 18, 2021
ConversationCommits (1)ChecksFiles changed
Merged

Enable tests for text path based markers#21377
QuLogic merged 1 commit into
matplotlib:masterfrom
deep-jkl:enable_text_marker_tests

Conversation

deep-jkl commented Oct 18, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

This PR uncomments marker tests which required instances of TextPath. These tests were introduced (and unfortunately just commented out) in PR #20914, and can be used since #21280 is merged.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

anntzer approved these changes Oct 18, 2021
View reviewed changes

anntzer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

modulo CI.

QuLogic added this to the v3.6.0 milestone Oct 18, 2021
QuLogic merged commit 9568e14 into matplotlib:master Oct 18, 2021
tacaswell pushed a commit that referenced this pull request Oct 20, 2021
Merge pull request #21377 from deep-jkl/enable_text_marker_tests
92b208a 
Enable tests for text path based markers
deep-jkl deleted the enable_text_marker_tests branch April 13, 2022 18:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

QuLogic QuLogic approved these changes
anntzer anntzer approved these changes

Assignees

No one assigned

Labels

topic: testing

Projects

None yet

Milestone

v3.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL