Repository navigation
Expire _check_savefig_extra_args-related deprecations. - #21395
Merged
QuLogic merged 1 commit intoDec 7, 2021
Merged
QuLogic merged 1 commit into
QuLogic merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
anntzer
force-pushed
the
csea
branch
3 times, most recently
from
39a971b to
dd078ab
Compare
October 20, 2021 12:33
6 tasks
QuLogic
reviewed
Nov 23, 2021
Comment thread
doc/api/next_api_changes/removals/21395-AL.rst
Outdated
Comment thread
lib/matplotlib/backend_bases.py
Outdated
Copy link
Copy Markdown
Member
|
I took the liberty of rebasing (I broke it in #21705 ). |
Sorry, something went wrong.
tacaswell
approved these changes
Dec 1, 2021
tacaswell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I agree the name of the context manager could be better, but it is internal so the stakes of getting in wrong are lower.
Sorry, something went wrong.
i.e. make print_figure() error on non-supported kwargs. We can further remove the need to decorate each and every print_method by instead doing the wrapping when fetching the method instead; this wrapping is done in a _switch_canvas_and_return_print_method helper.
QuLogic
approved these changes
Dec 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i.e. make print_figure() error on non-supported kwargs.
We can further remove the need to decorate each and every print_method
by instead doing the wrapping when fetching the method instead; this
wrapping is done in a _switching_canvas_and_get_print_method helper.
PR Summary
PR Checklist