FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Backport #21429 from jklymak/doc-use-mpl-sphinx by jklymak · Pull Request #21461 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Backport #21429 from jklymak/doc-use-mpl-sphinx - #21461

Merged
timhoffm merged 2 commits into
matplotlib:v3.5.xfrom
jklymak:backport-21429
Oct 26, 2021
ConversationCommits (2)ChecksFiles changed
Merged

Backport #21429 from jklymak/doc-use-mpl-sphinx#21461
timhoffm merged 2 commits into
matplotlib:v3.5.xfrom
jklymak:backport-21429

Conversation

jklymak commented Oct 25, 2021

Copy link
Copy Markdown
Member

DOC: use mpl-sphinx-theme for navbar, social, logo

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Merge pull request matplotlib#21429 from jklymak/doc-use-mpl-sphinx
eb58c94 
DOC: use mpl-sphinx-theme for navbar, social, logo
jklymak changed the title Merge pull request #21429 from jklymak/doc-use-mpl-sphinx Backport #21429 from jklymak/doc-use-mpl-sphinx Oct 25, 2021
timhoffm reviewed Oct 25, 2021
View reviewed changes
Comment thread requirements/doc/doc-requirements.txt Outdated
numpydoc>=0.8
packaging>=20
pydata-sphinx-theme>=0.6.0
pyparsing<3.0.0

timhoffm Oct 25, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is not needed anymore due to #21454.

jklymak commented Oct 25, 2021
View reviewed changes
Comment thread requirements/doc/doc-requirements.txt Outdated
jklymak commented Oct 26, 2021
View reviewed changes

jklymak left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The only "controversial" thing here is back porting environment.yml @timhoffm I think you introduced this file - is there any reason to not back port it? I admit I am back porting it due to poor cherry-picking skills, but left it in there anyway.

timhoffm approved these changes Oct 26, 2021
View reviewed changes

timhoffm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Backporting environment.yml is not really necessary. The main use is creating a dev environement for the current master. OTOH future version branches will have their then-current environment.yml. So it's also no harm to have the backport in 3.5.

timhoffm added this to the v3.5.0 milestone Oct 26, 2021
timhoffm merged commit 13a439b into matplotlib:v3.5.x Oct 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL