| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
ooooh or better would be something like pip install -i https://pypi.anaconda.org/scipy-wheels-nightly/simple matplotlib as in #21634 |
Sorry, something went wrong.
There was a problem hiding this comment.
We should be uploading to SciPy's nightly channel instead. I think that's waiting on @tacaswell for some keys.
Sorry, something went wrong.
|
Thank you for prodding me to make progress on this. Current state: I have sorted out who to ask and have (just) provided them with my anaconda.org user name. Once I have that set up I'll sort out which secrets I need to put where... |
Sorry, something went wrong.
|
@ianhi, I like how you're thinking with all these PRs :) I think you can add an on: schedule: cron to this file, and then on your new upload to scipy nightly step put in something like: if: ${{ github.event_name == 'schedule' }} @tacaswell, It looks like most other projects don't upload wheels every night, so you might want to check and see what an acceptable/preferred cadence is there too. |
Sorry, something went wrong.
Yeah, something like weekly would also be totally fine that's still much faster than the mpl release cadence :). It would be handy if it would be well documented when this upload happened so that cron jobs that depend on that upload can happen a bit after. e.g. this upload will always happen at ___ on sunday |
Sorry, something went wrong.
|
Update: I have the login/access, but have not generated the secrets yet (on my to-do for tomorrow). Consensus is nightly is OK. |
Sorry, something went wrong.
|
There is now a token ANACONDA_ORG_UPLOAD_TOKEN which will be available on non-PRs in the GHA secrets. |
Sorry, something went wrong.
|
https://github.com/h5py/h5py/blob/master/ci/upload_wheels.sh <- this is how h5py is doing the upload. |
Sorry, something went wrong.
|
We should also probably add some documentation about where these wheels can be found somewhere too once we upload them. Then this PR will close #9994 |
Sorry, something went wrong.
|
@ianhi, feel free to pop out of draft when ready... |
Sorry, something went wrong.
|
@ianhi 👋 Thanks for getting this PR going and for all the work that you've done on moving nightly wheels forward in general. 🙏 Now that @tacaswell has the ANACONDA_ORG_UPLOAD_TOKEN available as a repository secret and h5py has an upload recipe that can be adopted to a GHA workflow, do you think this is something that could move forward soon? I can fully appreciate that you most probably have other works that is more pressing at the moment. So I would be happy to help get a GHA workflow for this. (Apologies in advance to you and the maintainers for the noise if this is currently on hold for other reasons not documented in this PR.) |
Sorry, something went wrong.
I think this is on hold because I forgot about it and then was traveling when jody sent a reminder and so forgot once more :(
by all means have at it :) - I'm actually traveling again on Friday and we know how that impacted things last time.... |
Sorry, something went wrong.
100% understand. Been there many many times. :)
SGTM. 👍 I'll try to get something that looks reasonable on a branch on my fork going and then discuss it back on Issue #21635 before adding something else into the mix. Safe travels! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
Add a second artifact upload to the wheels that build on every merge to main. This is a subset of the wheels upload but should be significantly smaller to enable fast downloading for 3rd party tests in CI.
Closes: #21635