Repository navigation
FIX: Make sure a renderer gets attached to figure after draw - #21758
Merged
dstansby merged 1 commit intoNov 28, 2021
Merged
dstansby merged 1 commit into
dstansby merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Make sure that a cached renderer gets added to the figure after calling fig.canvas.draw()
Copy link
Copy Markdown
Member
|
This is legacy from when the OSX backend was not Agg based, but was implemented on top of the OSX native drawing API. In that API we could only get a graphics context inside of the UI draw loop, hence we had to use draw_idle and force the UI event loop to spin. Now that the OSX backend is Agg based, we do not have this restriction and can make OSX behave more in line with the other Agg-based GUI backends. |
Sorry, something went wrong.
tacaswell
approved these changes
Nov 26, 2021
dstansby
approved these changes
Nov 28, 2021
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 28, 2021
… to figure after draw
dstansby
added a commit
that referenced
this pull request
Nov 28, 2021
…758-on-v3.5.x Backport PR #21758 on branch v3.5.x (FIX: Make sure a renderer gets attached to figure after draw)
6 tasks
imgbot Bot
pushed a commit
to kkipngenokoech/matplotlib
that referenced
this pull request
Apr 19, 2026
… to figure after draw
imgbot Bot
pushed a commit
to kkipngenokoech/matplotlib
that referenced
this pull request
Apr 19, 2026
… to figure after draw
imgbot Bot
pushed a commit
to kkipngenokoech/matplotlib
that referenced
this pull request
Apr 19, 2026
… to figure after draw
imgbot Bot
pushed a commit
to kkipngenokoech/matplotlib
that referenced
this pull request
Apr 19, 2026
… to figure after draw
imgbot Bot
pushed a commit
to kkipngenokoech/matplotlib
that referenced
this pull request
Apr 19, 2026
… to figure after draw
imgbot Bot
pushed a commit
to kkipngenokoech/matplotlib
that referenced
this pull request
Apr 19, 2026
… to figure after draw
imgbot Bot
pushed a commit
to kkipngenokoech/matplotlib
that referenced
this pull request
Apr 19, 2026
… to figure after draw
imgbot Bot
pushed a commit
to kkipngenokoech/matplotlib
that referenced
this pull request
Apr 19, 2026
… to figure after draw
imgbot Bot
pushed a commit
to kkipngenokoech/matplotlib
that referenced
this pull request
Apr 19, 2026
… to figure after draw
imgbot Bot
pushed a commit
to kkipngenokoech/matplotlib
that referenced
this pull request
Apr 19, 2026
… to figure after draw
imgbot Bot
pushed a commit
to kkipngenokoech/matplotlib
that referenced
this pull request
Apr 19, 2026
… to figure after draw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Make sure that a cached renderer gets added to the figure after calling fig.canvas.draw() on the macosx backend. This changes the draw path to go through adding a renderer to the figure first.
closes #19197
closes #13968
closes #7550
PR Checklist
Tests and Styling
Documentation