FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

DOC: remove experimental tag from CL by jklymak · Pull Request #21975 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

DOC: remove experimental tag from CL - #21975

Merged
jklymak merged 1 commit into
matplotlib:mainfrom
jklymak:doc-CL-not-expertimental
Dec 17, 2021
ConversationCommits (1)ChecksFiles changed
Merged

DOC: remove experimental tag from CL#21975
jklymak merged 1 commit into
matplotlib:mainfrom
jklymak:doc-CL-not-expertimental

Conversation

jklymak commented Dec 16, 2021

Copy link
Copy Markdown
Member

PR Summary

Constrained layout is not really experimental any more, and we probably should not break it at this point....

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

jklymak commented Dec 16, 2021

Copy link
Copy Markdown
Member Author

Note I also adjusted the Figure layout docstring. I think both layout managers suffer performance constraints, just the worse ones for constrained_layout you simply wouldn't even expect anything sensible from tight_layout.

jklymak force-pushed the doc-CL-not-expertimental branch from bd740ce to 3a4c0fb Compare December 16, 2021 12:36
dstansby added this to the v3.6.0 milestone Dec 16, 2021
dstansby approved these changes Dec 16, 2021
View reviewed changes

dstansby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

With an optional suggestion

Comment thread lib/matplotlib/figure.py Outdated
Comment on lines +2218 to +2219
layout managers can have significant performance penalties as
they require an extra draw and solve an inverse problem.

dstansby Dec 16, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
layout managers can have significant performance penalties as
they require an extra draw and solve an inverse problem.
layout managers can have significant performance penalties.

For brevity, I don't think we need to explain why?

tacaswell Dec 16, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm weakly in favor of brevity here as well.

jklymak Dec 17, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done...

tacaswell approved these changes Dec 16, 2021
View reviewed changes

tacaswell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Same as @dstansby

@jklymak can self-merge with or without the wording change.

jklymak force-pushed the doc-CL-not-expertimental branch from 3a4c0fb to 8cbe67e Compare December 17, 2021 07:50
jklymak merged commit e3555f5 into matplotlib:main Dec 17, 2021
jklymak deleted the doc-CL-not-expertimental branch December 17, 2021 08:45
QuLogic mentioned this pull request Sep 9, 2022
Merged
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tacaswell tacaswell approved these changes
dstansby dstansby approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL