FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ENH: Use rcParams savefig.directory on macosx backend by greglucas · Pull Request #22180 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

ENH: Use rcParams savefig.directory on macosx backend - #22180

Merged
jklymak merged 2 commits into
matplotlib:mainfrom
greglucas:macosx-savefig
May 18, 2022
ConversationCommits (2)ChecksFiles changed
Merged

ENH: Use rcParams savefig.directory on macosx backend#22180
jklymak merged 2 commits into
matplotlib:mainfrom
greglucas:macosx-savefig

Conversation

greglucas commented Jan 10, 2022

Copy link
Copy Markdown
Contributor

PR Summary

This adds the rcParams savefig.directory option into the macosx
backend for the savefig dialog window.

Additionally cleans up some of the UTF8 string allocations in this code block.

Closes #21710

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

greglucas added this to the v3.6.0 milestone Jan 10, 2022
dstansby reviewed Jan 10, 2022
View reviewed changes
Comment thread lib/matplotlib/backends/backend_macosx.py
self.canvas.remove_rubberband()

def save_figure(self, *args):
directory = os.path.expanduser(mpl.rcParams['savefig.directory'])

dstansby Jan 10, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is it possible to add a smoke test for this in the tests?

greglucas Jan 10, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Unfortunately I think this is another PR that would be quite hard to add a test for because it is using the GUI :( I did a global search and didn't see any of the other backends testing this either...

greglucas Jan 10, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I take that back, I just pushed up a test to hijack the GUI function and return a well-defined string instead. I think that should get codecov for the Python branches at least... Still not testing the Objective-C updates, but better than nothing?

greglucas force-pushed the macosx-savefig branch 2 times, most recently from 647451d to bd7d627 Compare January 10, 2022 16:25
greglucas requested a review from dstansby March 5, 2022 18:17
QuLogic reviewed Mar 8, 2022
View reviewed changes
Comment thread lib/matplotlib/tests/test_backend_macosx.py Outdated
ENH: Use rcParams savefig.directory on macosx backend
326ea1a 
This adds the rcParams savefig.directory option into the macosx
backend for the savefig dialog window.

greglucas commented Apr 10, 2022

Copy link
Copy Markdown
Contributor Author

Ping for a review from any mac users that want to test this out.

greglucas commented May 15, 2022

Copy link
Copy Markdown
Contributor Author

@dstansby / mac users, reminder for another review on this one as well.

  • You should be able to set the savefig directory with rcParams now
  • The previously saved directory should be the default directory upon a second save figure request. (Save to /tmp the first time, and then the next time it should bring up /tmp as the default save location)

jklymak merged commit dd001ed into matplotlib:main May 18, 2022
QuLogic mentioned this pull request Sep 9, 2022
Merged
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

QuLogic QuLogic left review comments
tacaswell tacaswell approved these changes
jklymak jklymak approved these changes
dstansby Awaiting requested review from dstansby

Assignees

No one assigned

Labels

GUI: MacOSX

Projects

None yet

Milestone

v3.6.0

Development

Successfully merging this pull request may close these issues.

[ENH]: macosx backend does not respect rcParams["savefig.directory"]

5 participants

Back | FazBrowse Home | New Git URL