FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Backport PR #21833: Enforce backport conditions on v*-doc branches by tacaswell · Pull Request #22221 · matplotlib/matplotlib · GitHub

Repository navigation

Backport PR #21833: Enforce backport conditions on v*-doc branches - #22221

Merged
QuLogic merged 1 commit into
matplotlib:v3.5.1-docfrom
tacaswell:auto-backport-of-pr-21833-on-v3.5.1-doc
Jan 19, 2022
Merged

QuLogic merged 1 commit into
matplotlib:v3.5.1-docfrom
tacaswell:auto-backport-of-pr-21833-on-v3.5.1-doc

Conversation

Copy link
Copy Markdown
Member

Merge pull request #21833 from QuLogic/clean-doc-backports

CI: Enforce backport conditions on v*-doc branches

…ranches

Merge pull request matplotlib#21833 from QuLogic/clean-doc-backports

CI: Enforce backport conditions on v*-doc branches
tacaswell added this to the v3.5-doc milestone Jan 12, 2022
timhoffm closed this Jan 17, 2022
timhoffm reopened this Jan 17, 2022

Copy link
Copy Markdown
Member Author

This is failing on the changes in float results due to the SIMD instructions that numpy now ships with in their wheel. We need to do one of:

  • backport the tolerance increase
  • pin back numpy
  • use the envs variables to turn off the SIMD instructions
  • turn off everything but doc building and publishing on these branchs

I lean towards the last option (turn off tests on the docs branch).

QuLogic commented Jan 18, 2022

Copy link
Copy Markdown
Member

They're already supposed to be off, but this only covers direct pushes, and not PR targets.

QuLogic commented Jan 18, 2022

Copy link
Copy Markdown
Member

See #22256

tacaswell closed this Jan 18, 2022
tacaswell reopened this Jan 18, 2022
QuLogic closed this Jan 19, 2022
QuLogic reopened this Jan 19, 2022

QuLogic commented Jan 19, 2022

Copy link
Copy Markdown
Member

Ah, even though it appears that test were run here, they are the original ones from the last time. Since they didn't run again, the old statuses were not removed.

QuLogic merged commit feb68c7 into matplotlib:v3.5.1-doc Jan 19, 2022
tacaswell deleted the auto-backport-of-pr-21833-on-v3.5.1-doc branch January 19, 2022 22:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL