| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
TST: fix the tests
|
Thanks! |
Sorry, something went wrong.
|
Should the api change now be adapted as well? |
Sorry, something went wrong.
|
Hmmm, I don't think I put in an API change note for the original deprecation, which was an oversight. |
Sorry, something went wrong.
|
So now that I think about this a bit more, do we really want to get rid of figure.set_tight_layout()? That is used massively in the wild. |
Sorry, something went wrong.
|
I'd definitively get rid of get/set_constrained_layout_pads(). That's too specific for a figure method. But we're not in a hurry let's go an normal deprecation cycle here, including a pending round. set_tight_layout/set_constrained_layout: In the very long run, we want to get rid of it because of the duplicate API. But there are 7.5k usages on GitHub, so I think a deprecation would be too annoying. I think we have to give a long lead to let it grow out to some extent.
|
Sorry, something went wrong.
|
OK, so left the pending deprecations in, but changed the deprecation note to say that set_tight/constrained_layout are discouraged rather than that they will be deprecated. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Summary
Closes #22343
As noted there, deprecating immediately emits a DeprecationWarning, whereas this will emit a PendingDeprecationWarning.
PR Checklist
Tests and Styling
Documentation