FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Deprecation removal/updates in axes3d by oscargus · Pull Request #22366 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Deprecation removal/updates in axes3d - #22366

Merged
QuLogic merged 2 commits into
matplotlib:mainfrom
oscargus:axes3ddeprecations
Feb 23, 2022
ConversationCommits (2)ChecksFiles changed
Merged

Deprecation removal/updates in axes3d#22366
QuLogic merged 2 commits into
matplotlib:mainfrom
oscargus:axes3ddeprecations

Conversation

oscargus commented Jan 31, 2022

Copy link
Copy Markdown
Member

PR Summary

Removed deprecated support for shade=None, will add release note.

Updated documentation and removal version for auto_add_to_figure. Should there be a release note for this? If so, not obvious in which category. (I assume that this should not go into 3.5 now?)

There are also:

matplotlib/lib/mpl_toolkits/mplot3d/axes3d.py

Lines 236 to 241 in 6eba0af

w_xaxis = _api.deprecated("3.1", alternative="xaxis", pending=True)(
property(lambda self: self.xaxis))
w_yaxis = _api.deprecated("3.1", alternative="yaxis", pending=True)(
property(lambda self: self.yaxis))
w_zaxis = _api.deprecated("3.1", alternative="zaxis", pending=True)(
property(lambda self: self.zaxis))

Should the pending be removed? If so, removal in two versions or later? Release note?

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

timhoffm commented Jan 31, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Please fix the flake8 issue:

./lib/mpl_toolkits/tests/test_mplot3d.py:9:1: F401 'matplotlib.cbook.MatplotlibDeprecationWarning' imported but unused

oscargus marked this pull request as draft January 31, 2022 21:43
oscargus mentioned this pull request Feb 1, 2022
Closed
oscargus marked this pull request as ready for review February 19, 2022 14:53
oscargus added API: changes Changes to the public API, typically requiring deprecation. Maintenance status: needs review labels Feb 19, 2022
QuLogic merged commit 9ab5aad into matplotlib:main Feb 23, 2022
QuLogic added this to the v3.6.0 milestone Feb 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

QuLogic QuLogic approved these changes
timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

API: changes Changes to the public API, typically requiring deprecation. Maintenance

Projects

None yet

Milestone

v3.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL