FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Clarify note in get_cmap() by timhoffm · Pull Request #22396 · matplotlib/matplotlib · GitHub

Repository navigation

Clarify note in get_cmap() - #22396

Merged
QuLogic merged 1 commit into
matplotlib:mainfrom
timhoffm:doc-cmap-copy
Feb 8, 2022
Merged

QuLogic merged 1 commit into
matplotlib:mainfrom
timhoffm:doc-cmap-copy

Conversation

timhoffm commented Feb 4, 2022

Copy link
Copy Markdown
Member

PR Summary

Closes #22362.

timhoffm added this to the v3.5.2 milestone Feb 4, 2022

jklymak commented Feb 5, 2022

Copy link
Copy Markdown
Member

@mwaskom is this ok for the original issue?

mwaskom commented Feb 5, 2022

Copy link
Copy Markdown

Yep that resolves the ambiguity of the original text. Should the note also flag matplotlib.colormaps? I guess I’m still slightly confused about what the situation will be in 3.6; will there just be 3 different ways to get a copy of a colormap object? (mpl.colormaps, mpl.cm.get_cmap, mpl.cm.<name>)?

timhoffm commented Feb 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

mpl.colormaps will eventually become the default and other cm access methods will be deprecated. However, as long as mpl.colormaps is experimental, I don't want to actively drive people away from mpl.cm.get_cmap. See https://matplotlib.org/stable/users/prev_whats_new/whats_new_3.5.0.html#colormap-registry-experimental for more information.

When the experimental status gets removed, we'll advertise colormaps more loudly.

QuLogic merged commit 5502dee into matplotlib:main Feb 8, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 8, 2022
timhoffm deleted the doc-cmap-copy branch February 8, 2022 07:47
timhoffm added a commit that referenced this pull request Feb 8, 2022
…396-on-v3.5.x

Backport PR #22396 on branch v3.5.x (Clarify note in get_cmap())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc]: Deprecation note in get_cmap is non-actionable

4 participants


Back | FazBrowse Home | New Git URL