FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix Radar Chart Gridlines for Non-Circular Charts by prohde · Pull Request #22458 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Fix Radar Chart Gridlines for Non-Circular Charts - #22458

Merged
anntzer merged 1 commit into
matplotlib:mainfrom
prohde:radar_chart_example
Feb 13, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Fix Radar Chart Gridlines for Non-Circular Charts#22458
anntzer merged 1 commit into
matplotlib:mainfrom
prohde:radar_chart_example

Conversation

prohde commented Feb 12, 2022

Copy link
Copy Markdown
Contributor

This PR fixes the gridlines for non-circular radar charts. This fixes #19981. Starting with version 3.3.0 the autoconversion to circular arcs in PolarAxes.PolarTransform forced all gridlines to be circular. This PR provides the necessary changes in the example for radar charts to produce gridlines of the same shape as the frame.

Many thanks to @anntzer for identifying the cause of the problem and distilling the proposed fix to a minimal solution.

github-actions Bot reviewed Feb 12, 2022
View reviewed changes

github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

anntzer added this to the v3.5-doc milestone Feb 13, 2022

anntzer commented Feb 13, 2022

Copy link
Copy Markdown
Contributor

Thanks, this looks great!
Hoping to see you around again in the future.

anntzer merged commit cc71742 into matplotlib:main Feb 13, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 13, 2022
Backport PR matplotlib#22458: Fix Radar Chart Gridlines for Non-Circu…
aab6280 
…lar Charts
This was referenced Feb 13, 2022
Merged
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 13, 2022
Backport PR matplotlib#22458: Fix Radar Chart Gridlines for Non-Circu…
9fdb877 
…lar Charts
anntzer mentioned this pull request Feb 13, 2022
Merged
6 tasks
timhoffm added a commit that referenced this pull request Feb 13, 2022
Merge pull request #22462 from meeseeksmachine/auto-backport-of-pr-22…
4785d0a 
…458-on-v3.5.x

Backport PR #22458 on branch v3.5.x (Fix Radar Chart Gridlines for Non-Circular Charts)
timhoffm added a commit that referenced this pull request Feb 13, 2022
Merge pull request #22463 from meeseeksmachine/auto-backport-of-pr-22…
a91b3a0 
…458-on-v3.5.1-doc

Backport PR #22458 on branch v3.5.1-doc (Fix Radar Chart Gridlines for Non-Circular Charts)
anntzer mentioned this pull request Feb 22, 2022
Closed
imgbot Bot pushed a commit to kkipngenokoech/matplotlib that referenced this pull request Apr 19, 2026
Backport PR matplotlib#22458: Fix Radar Chart Gridlines for Non-Circu…
c010e11 
…lar Charts
imgbot Bot pushed a commit to kkipngenokoech/matplotlib that referenced this pull request Apr 19, 2026
Backport PR matplotlib#22458: Fix Radar Chart Gridlines for Non-Circu…
c2f240b 
…lar Charts
imgbot Bot pushed a commit to kkipngenokoech/matplotlib that referenced this pull request Apr 19, 2026
Backport PR matplotlib#22458: Fix Radar Chart Gridlines for Non-Circu…
5d8462c 
…lar Charts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

github-actions[bot] github-actions[bot] left review comments
anntzer anntzer approved these changes

Assignees

No one assigned

Labels

Documentation topic: polar

Projects

None yet

Milestone

v3.5-doc

Development

Successfully merging this pull request may close these issues.

Radar Chart with Polygonal Grid Lines

2 participants

Back | FazBrowse Home | New Git URL