| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Sorry, something went wrong.
There was a problem hiding this comment.
This seems fine if the original reporter says it works. I cannot reproduce the issue in Chromium.
Sorry, something went wrong.
|
I don't think this is correct, e.g. rcParams["svg.fonttype"] = "none"; figtext(.5, .5, "hello", font="DejaVu Sans"); savefig("/tmp/test.svg")
results in <text style="font: 10px 'DejaVu Sans', DejaVu Sans; text-anchor: start" x="230.4" y="172.8" transform="rotate(-0 230.4 172.8)">hello</text> where the unquoted DejaVu Sans is likely wrong? (at least wrt. the spec) |
Sorry, something went wrong.
|
@not-so-rabh could you comment on @anntzer's question? |
Sorry, something went wrong.
|
Converted to draft - needs discussion and rebase |
Sorry, something went wrong.
|
The issue that @anntzer points out is real, we need to only add the un-escaped font name if the name is one of the generic names. There is also some confusion about what get_name and get_family on FontProperties do. get_family gives back the list of font names (which font tools call families) and get_name turns the crank on our font search code and return the family of the font actually found on the users system. This line of code also was impacted by #23559 and the fix for #23492 will also touch this line. I think I see how to fix both #22528 and #23492 in one shot and in the interest of trying to squeeze these in for 3.6 am just going to do it. Thank you for your work on this @not-so-rabh , I apologize for taking this issue from under you, and I hope we hear from you again! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Fixes #22528