| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| from matplotlib.testing.conftest import (mpl_test_settings, | ||
| pytest_configure, pytest_unconfigure, | ||
| pd) | ||
| pd, xr) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| Expand Up | @@ -680,14 +680,37 @@ def test_reshape2d_pandas(pd): | |
| for x, xnew in zip(X.T, Xnew): | ||
| np.testing.assert_array_equal(x, xnew) | ||
|
|
||
|
|
||
| def test_reshape2d_xarray(xr): | ||
| # separate to allow the rest of the tests to run if no xarray... | ||
| X = np.arange(30).reshape(10, 3) | ||
| x = pd.DataFrame(X, columns=["a", "b", "c"]) | ||
| x = xr.DataArray(X, dims=["x", "y"]) | ||
| Xnew = cbook._reshape_2D(x, 'x') | ||
| # Need to check each row because _reshape_2D returns a list of arrays: | ||
| for x, xnew in zip(X.T, Xnew): | ||
| np.testing.assert_array_equal(x, xnew) | ||
|
|
||
|
|
||
| def test_index_of_pandas(pd): | ||
| # separate to allow the rest of the tests to run if no pandas... | ||
| X = np.arange(30).reshape(10, 3) | ||
| x = pd.DataFrame(X, columns=["a", "b", "c"]) | ||
| Idx, Xnew = cbook.index_of(x) | ||
| np.testing.assert_array_equal(X, Xnew) | ||
| IdxRef = np.arange(10) | ||
| np.testing.assert_array_equal(Idx, IdxRef) | ||
|
|
||
|
|
||
| def test_index_of_xarray(xr): | ||
|
Comment thread
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityDoes xarray get us more coverage here? They have a to_numpy() method the same as pandas I believe. So, it seems like a pretty heavy dependency to add for just this one test...
Sorry, something went wrong.
jklymak reacted with thumbs up emoji
All reactions
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityNot so much for coverage as for actually testing using data of specified formats. With the discussion about which formats we support, it makes sense to test them as well. Right now some of these are tested in the plots, but it can possibly make sense to simply test them here as these are the core function used to get data that can be plotted. If we claim (which we actually don't, maybe we should?) that we can plot xarray, we should probably test it as well. And other types that we may want to claim to support. Or maybe fork off a specific dependency test that is not executed on all platforms/version, including pandas (which is 11.7 MB, xarray is 870 kB). (There is another xarray-test above, so two.) I can of course remove them, but I think we should discuss if we want to support more formats than pandas and numpy (and Python list/tuple), and, if so, have explicit tests for them.
Sorry, something went wrong.
All reactions
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityI agree, we should probably discuss what we want to support/test. To me, this doesn't seem to add a whole lot of value for adding a new dependency. There was also a discussion around removing Scipy as a dependency in the docs: #22120
Sorry, something went wrong.
All reactions
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityI removed the dependencies but kept the tests. Hence, they will run if xarray is available. I also opened #22645 for discussions (probably should be discussed at a dev-call as well).
Sorry, something went wrong.
All reactions
|
||
| # separate to allow the rest of the tests to run if no xarray... | ||
| X = np.arange(30).reshape(10, 3) | ||
| x = xr.DataArray(X, dims=["x", "y"]) | ||
| Idx, Xnew = cbook.index_of(x) | ||
| np.testing.assert_array_equal(X, Xnew) | ||
| IdxRef = np.arange(10) | ||
| np.testing.assert_array_equal(Idx, IdxRef) | ||
|
|
||
|
|
||
| def test_contiguous_regions(): | ||
| a, b, c = 3, 4, 5 | ||
| # Starts and ends with True | ||
| Expand Down | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| Expand Up | @@ -7,3 +7,4 @@ pandas!=0.25.0 | |
| pikepdf | ||
| pytz | ||
| pywin32; sys.platform == 'win32' | ||
| xarray | ||
| Back | FazBrowse Home | New Git URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityPlease document what we intend to support, i.e. everything with .to_numpy() or .values, and what types we expect to catch with it, e.g. values-> older pandas dataframes(?).
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.