Repository navigation
ENH: Add dark/light mode theme to the buttons - #22607
Merged
timhoffm merged 1 commit intoMar 5, 2022
Merged
timhoffm merged 1 commit into
timhoffm merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This makes the images used for the buttons a template image which can be adjusted based on the system theme chosen by the user.
dstansby
reviewed
Mar 5, 2022
dstansby
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Awesome!
Sorry, something went wrong.
dstansby
approved these changes
Mar 5, 2022
timhoffm
approved these changes
Mar 5, 2022
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This makes the images used for the buttons a template image which can be adjusted based on the system theme chosen by the user. The text in the toolbar when hovering an image already follows the theme changing from white/black appropriately.
Light mode:
Dark mode:
Closes #22605
PR Checklist
Tests and Styling
Documentation