FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Backport PR #22691 on branch v3.5.x (FIX: remove toggle on QuadMesh cursor data) by meeseeksmachine · Pull Request #22701 · matplotlib/matplotlib · GitHub

Repository navigation

Backport PR #22691 on branch v3.5.x (FIX: remove toggle on QuadMesh cursor data) - #22701

Merged
tacaswell merged 2 commits into
matplotlib:v3.5.xfrom
meeseeksmachine:auto-backport-of-pr-22691-on-v3.5.x
Mar 29, 2022
Merged

tacaswell merged 2 commits into
matplotlib:v3.5.xfrom
meeseeksmachine:auto-backport-of-pr-22691-on-v3.5.x

Conversation

Copy link
Copy Markdown
Contributor

Backport PR #22691: FIX: remove toggle on QuadMesh cursor data

lumberbot-app Bot added this to the v3.5.2 milestone Mar 25, 2022
lumberbot-app Bot added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Mar 25, 2022

New in 3.5, `.QuadMesh.get_cursor_data` allows display of data values
under the cursor. However, this can be very slow for large meshes, so
by `.QuadMesh.set_mouseover` defaults to *False*. No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
by `.QuadMesh.set_mouseover` defaults to *False*.
by ``.QuadMesh.set_mouseover`` defaults to *False*.

? As this doesn't exist in 3.5.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Or actually the attribute directly?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Since it doesn't exist in 3.5, this should be the attribute.

Copy link
Copy Markdown
Member

The issue is that while obj.set_mouseover has existed for a long time, it is documented https://matplotlib.org/devdocs/api/_as_gen/matplotlib.artist.Artist.set_mouseover.html as Artist.set_mouseover and sphinx is not forwarding correctly.

tacaswell merged commit 9687a2a into matplotlib:v3.5.x Mar 29, 2022
Carreau deleted the auto-backport-of-pr-22691-on-v3.5.x branch April 12, 2022 10:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL