FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Small style fixes. by anntzer · Pull Request #22721 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Small style fixes. - #22721

Merged
timhoffm merged 1 commit into
matplotlib:mainfrom
anntzer:style
Mar 29, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Small style fixes.#22721
timhoffm merged 1 commit into
matplotlib:mainfrom
anntzer:style

Conversation

anntzer commented Mar 28, 2022

Copy link
Copy Markdown
Contributor

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

tacaswell reviewed Mar 28, 2022
View reviewed changes
Comment thread lib/matplotlib/backends/backend_svg.py
Affine2D()
.scale(1.0, -1.0)
.translate(0.0, self.height))
return transform + Affine2D().scale(1, -1).translate(0, self.height)

tacaswell Mar 28, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The multi-line version is arguably more readable but not going to block over that.

timhoffm Mar 29, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

+/-0

tacaswell added this to the v3.7.0 milestone Mar 28, 2022
timhoffm approved these changes Mar 29, 2022
View reviewed changes
Comment thread lib/matplotlib/backends/backend_svg.py
Affine2D()
.scale(1.0, -1.0)
.translate(0.0, self.height))
return transform + Affine2D().scale(1, -1).translate(0, self.height)

timhoffm Mar 29, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

+/-0

timhoffm commented Mar 29, 2022

Copy link
Copy Markdown
Member

@tacaswell you‘re milestoneing this as 3.7. have we already branched of 3.6?

oscargus reviewed Mar 29, 2022
View reviewed changes
Comment thread lib/matplotlib/legend.py Outdated
oscargus reviewed Mar 29, 2022
View reviewed changes
Comment thread lib/matplotlib/text.py Outdated
timhoffm modified the milestones: v3.7.0, v3.6.0 Mar 29, 2022

timhoffm commented Mar 29, 2022

Copy link
Copy Markdown
Member

We have not yet branched 3.6 off from main, so the canoncial target is 3.6.0.

timhoffm merged commit ccf5115 into matplotlib:main Mar 29, 2022
anntzer deleted the style branch March 29, 2022 15:34

tacaswell commented Mar 29, 2022

Copy link
Copy Markdown
Member

I miss-clicked, but I did make the 3.7 milestone for stuff we know we want to push out.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

oscargus oscargus left review comments
tacaswell tacaswell approved these changes
timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

Maintenance

Projects

None yet

Milestone

v3.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL