FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use system distutils instead of the setuptools copy by QuLogic · Pull Request #22756 · matplotlib/matplotlib · GitHub

  1. matplotlib
  2. matplotlib

Repository navigation

Use system distutils instead of the setuptools copy - #22756

Merged
tacaswell merged 1 commit into
matplotlib:mainfrom
QuLogic:fix-azure
Apr 1, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Use system distutils instead of the setuptools copy#22756
tacaswell merged 1 commit into
matplotlib:mainfrom
QuLogic:fix-azure

Conversation

QuLogic commented Apr 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

setuptools 60 re-enabled their local copy of distutils: pypa/setuptools#2896

This apparently fails to set up paths that can find msbuild, so switch back the standard library distutils.

PR Checklist

Tests and Styling

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).

QuLogic added the Build label Apr 1, 2022
QuLogic added this to the v3.5.2 milestone Apr 1, 2022
QuLogic force-pushed the fix-azure branch 2 times, most recently from 0dc232c to f5ab2e5 Compare April 1, 2022 03:56

QuLogic commented Apr 1, 2022

Copy link
Copy Markdown
Member Author

setuptools-59.8.0 worked; going to try something from 60. now.

QuLogic force-pushed the fix-azure branch 2 times, most recently from cf8d106 to ae0274f Compare April 1, 2022 04:15

QuLogic commented Apr 1, 2022

Copy link
Copy Markdown
Member Author

And setuptools-60.10.0 fails.

QuLogic force-pushed the fix-azure branch 2 times, most recently from 0e74630 to 8bd52b0 Compare April 1, 2022 04:27

QuLogic commented Apr 1, 2022

Copy link
Copy Markdown
Member Author

Dropping down to 60.0.0 fails as well, and the main change there is switching to setuptools' internal copy of distutils.

QuLogic changed the title Pin older setuptools on Azure Use system distutils instead of the setuptools copy Apr 1, 2022
QuLogic added the CI: Run cibuildwheel Run wheel building tests on a PR label Apr 1, 2022

QuLogic commented Apr 1, 2022

Copy link
Copy Markdown
Member Author

cibuildwheel is pinned to setuptools 56, though AppVeyor is on 61.3.0. Not sure I should set the env var on the former too, but maybe we'll just wait until an update allows installing a newer version.

QuLogic marked this pull request as ready for review April 1, 2022 06:08
oscargus added CI: Run cibuildwheel Run wheel building tests on a PR and removed CI: Run cibuildwheel Run wheel building tests on a PR labels Apr 1, 2022

tacaswell commented Apr 1, 2022

Copy link
Copy Markdown
Member

Do we need to document this in the install instructions as well?

I'm going to merge this to un-break CI.

tacaswell merged commit 20e38f4 into matplotlib:main Apr 1, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 1, 2022
Backport PR matplotlib#22756: Use system distutils instead of the set…
ea3c3bc 
…uptools copy
meeseeksmachine mentioned this pull request Apr 1, 2022
Merged
This was referenced Apr 1, 2022
Closed
Closed
Merged
QuLogic deleted the fix-azure branch April 1, 2022 20:00
oscargus added a commit that referenced this pull request Apr 4, 2022
Merge pull request #22764 from meeseeksmachine/auto-backport-of-pr-22…
65159a9 
…756-on-v3.5.x

Backport PR #22756 on branch v3.5.x (Use system distutils instead of the setuptools copy)
QuLogic mentioned this pull request Jan 25, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

oscargus oscargus approved these changes

Assignees

No one assigned

Labels

Build CI: Run cibuildwheel Run wheel building tests on a PR

Projects

None yet

Milestone

v3.5.2

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL