FIX: account for deprecations of constant in Pillow 9.1 by tacaswell · Pull Request #22766 · matplotlib/matplotlib · GitHub

https://pillow.readthedocs.io/en/stable/deprecations.html#constants

Image.None -> Image.Dither.None
Image.ADAPTIVE -> Image.Palette.ADAPTIVE

PR Summary

un-break CI by not triggering warnings from Pilllow

PR Checklist

Tests and Styling

[N/A] Has pytest style unit tests (and pytest passes).
Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

[N/A] New features are documented, with examples if plot related.
[N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
[N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
[N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

I know this style is odd, but these names a very long and this code is very indented.

I also tried

                dither = (
                    Image.Dither.NONE
                    if hasattr(Image, 'Dither')
                    else Image.NONE
                )

and liked that worse.

also tried doing this in-line in the function call, but that was also (subjectively) worse to my eye.

I have also just started seeing these temp file related failures locally (they go away on re-running). I had hoped it was because I was running too many unstable things, seeing if I can track this down...

I'm also a little confused because the version of Pillow that broke thing is 9.1, but the docs say 9.2.

This was a typo in the pillow docs: python-pillow/Pillow#6171

https://pillow.readthedocs.io/en/stable/deprecations.html#constants https://pillow.readthedocs.io/en/stable/releasenotes/9.1.0.html#constants Image.None -> Image.Dither.None Image.ADAPTIVE -> Image.Palette.ADAPTIVE

Why pin if the rest is going to fix it?

Why pin if the rest is going to fix it?

because it didn't fix it, some how bumping pillow exposed a leaking temporary directory...

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>

…in Pillow 9.1

…766-on-v3.5.x Backport PR #22766 on branch v3.5.x (FIX: account for constant deprecations in Pillow 9.1)

Re-reading the title of this issue. I just want to be clear this is about the deprecation of constants in Pillow, not a frequent stream of deprecations in Pillow....

tacaswell added this to the v3.5.2 milestone Apr 1, 2022

tacaswell mentioned this pull request Apr 1, 2022

Backport PR #22756 on branch v3.5.x (Use system distutils instead of the setuptools copy) #22764

Merged

tacaswell commented Apr 1, 2022

View reviewed changes

FIX: account for constant deprecations in Pillow 9.1

bb99770

https://pillow.readthedocs.io/en/stable/deprecations.html#constants https://pillow.readthedocs.io/en/stable/releasenotes/9.1.0.html#constants Image.None -> Image.Dither.None Image.ADAPTIVE -> Image.Palette.ADAPTIVE

matthewfeickert mentioned this pull request Apr 1, 2022

fix: Add filterwarnings ignore for Pillow DeprecationWarning scikit-hep/pyhf#1834

Merged

4 tasks done

tacaswell force-pushed the fix_pillow_compat branch from f219f8a to 8b0d527 Compare April 1, 2022 18:15

tacaswell changed the title FIX: account for constant deprecations in Pillow 9.2 FIX: account for constant deprecations in Pillow 9.1 Apr 1, 2022

tacaswell force-pushed the fix_pillow_compat branch from 8b0d527 to e3fea7e Compare April 1, 2022 21:50

tacaswell added 2 commits April 1, 2022 17:50

FIX: leaking temporary files in animation saving

a367714

CI: add pip list to azure pipeline

e3fea7e

STY: fix whitespace

f930098

tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Apr 1, 2022

QuLogic reviewed Apr 2, 2022

View reviewed changes

Comment thread lib/matplotlib/backends/backend_pdf.py Outdated

QuLogic reviewed Apr 2, 2022

View reviewed changes

Comment thread lib/matplotlib/animation.py

This was referenced Apr 3, 2022

TST: workaround upstream instabilities yt-project/yt#3882

Merged

filter upstream depr warning SAIL-Labs/AMICAL#131

Merged

rcomer mentioned this pull request Apr 4, 2022

Fix the error- TypeError: 'float' object is not iterable #22710

Merged

6 tasks

timhoffm approved these changes Apr 4, 2022

View reviewed changes

MNT: shorter version of Pillow API shims

bd6f04b

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>

oscargus approved these changes Apr 4, 2022

View reviewed changes

oscargus merged commit 4f5b310 into matplotlib:main Apr 4, 2022

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 4, 2022

Backport PR matplotlib#22766 : FIX: account for constant deprecations …

0205618

…in Pillow 9.1

meeseeksmachine mentioned this pull request Apr 4, 2022

Backport PR #22766 on branch v3.5.x (FIX: account for constant deprecations in Pillow 9.1) #22780

Merged

tacaswell deleted the fix_pillow_compat branch April 4, 2022 15:55

oscargus added a commit that referenced this pull request Apr 4, 2022

Merge pull request #22780 from meeseeksmachine/auto-backport-of-pr-22…

b042615

…766-on-v3.5.x Backport PR #22766 on branch v3.5.x (FIX: account for constant deprecations in Pillow 9.1)

tacaswell mentioned this pull request Apr 4, 2022

[TST] Upcoming dependency test failures #22772

Closed

tacaswell changed the title FIX: account for constant deprecations in Pillow 9.1 FIX: account for deprecations of constant in Pillow 9.1 Apr 5, 2022

-                                                palette=Image.ADAPTIVE, colors=num_colors)
+                              # These constants were converted to IntEnums and deprecated in
+                              # Pillow 9.2
+                              dither = (

FIX: account for deprecations of constant in Pillow 9.1 by tacaswell · Pull Request #22766 · matplotlib/matplotlib · GitHub

Repository navigation

FIX: account for deprecations of constant in Pillow 9.1 - #22766

FIX: account for deprecations of constant in Pillow 9.1#22766
oscargus merged 5 commits into
matplotlib:mainfrom
tacaswell:fix_pillow_compat

tacaswell commented Apr 1, 2022

Uh oh!

tacaswell Apr 1, 2022

Uh oh!

tacaswell commented Apr 1, 2022

Uh oh!

tacaswell commented Apr 1, 2022 •
edited
Loading

Uh oh!

Uh oh!

QuLogic commented Apr 1, 2022

Uh oh!

tacaswell commented Apr 1, 2022

Uh oh!

Uh oh!

Uh oh!

tacaswell commented Apr 5, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

FIX: account for deprecations of constant in Pillow 9.1 by tacaswell · Pull Request #22766 · matplotlib/matplotlib · GitHub

Repository navigation

FIX: account for deprecations of constant in Pillow 9.1 - #22766

FIX: account for deprecations of constant in Pillow 9.1#22766oscargus merged 5 commits intomatplotlib:mainmatplotlib/matplotlib:mainfrom tacaswell:fix_pillow_compattacaswell/matplotlib:fix_pillow_compatCopy head branch name to clipboard

Conversation

tacaswell commented Apr 1, 2022

PR Summary

PR Checklist

Uh oh!

tacaswell Apr 1, 2022

Choose a reason for hiding this comment

Uh oh!

tacaswell commented Apr 1, 2022

Uh oh!

tacaswell commented Apr 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

QuLogic commented Apr 1, 2022

Uh oh!

tacaswell commented Apr 1, 2022

Uh oh!

Uh oh!

Uh oh!

tacaswell commented Apr 5, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

FIX: account for deprecations of constant in Pillow 9.1#22766
oscargus merged 5 commits into
matplotlib:mainfrom
tacaswell:fix_pillow_compat

tacaswell commented Apr 1, 2022 •
edited
Loading