Repository navigation
Try to unbreak CI by xfailing OSX Tk tests - #23095
Merged
jklymak merged 3 commits intoMay 24, 2022
Merged
jklymak merged 3 commits into
jklymak merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Stopgap solution for matplotlib#23094
oscargus
reviewed
May 23, 2022
Comment thread
lib/matplotlib/tests/test_backend_tk.py
Outdated
oscargus
reviewed
May 23, 2022
Comment thread
lib/matplotlib/tests/test_backend_tk.py
Outdated
Copy link
Copy Markdown
Member
|
I believe that my second commit was the actual thing that corrected it. (Using pytest.mark.xfail rather than pytest.xfail, so one could get rid of my first commit. Or keep it as it still works.) |
Sorry, something went wrong.
anntzer
approved these changes
May 24, 2022
Copy link
Copy Markdown
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
git checkout v3.5.x git pull
git cherry-pick -x -m1 d6ee414ec175870b9fe8c65297e6c56114fe19a3
git commit -am 'Backport PR #23095: Try to unbreak CI by xfailing OSX Tk tests'
git push YOURFORK v3.5.x:auto-backport-of-pr-23095-on-v3.5.x
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the Still Needs Manual Backport label once the PR gets merged. If these instructions are inaccurate, feel free to suggest an improvement. |
Sorry, something went wrong.
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Jun 2, 2022
Try to unbreak CI by xfailing OSX Tk tests (matplotlib#23095) * Try to unbreak CI by xfailing OSX Tk tests Stopgap solution for matplotlib#23094 * Update lib/matplotlib/tests/test_backend_tk.py * Update lib/matplotlib/tests/test_backend_tk.py Co-authored-by: Oscar Gustafsson <oscar.gustafsson@gmail.com> (cherry picked from commit d6ee414)
oscargus
added a commit
that referenced
this pull request
Jun 3, 2022
…-v3.5.x Backport PR #23095: Try to unbreak CI by xfailing OSX Tk tests
andrew-fennell
pushed a commit
to andrew-fennell/matplotlib
that referenced
this pull request
Jun 14, 2022
* Try to unbreak CI by xfailing OSX Tk tests Stopgap solution for matplotlib#23094 * Update lib/matplotlib/tests/test_backend_tk.py * Update lib/matplotlib/tests/test_backend_tk.py Co-authored-by: Oscar Gustafsson <oscar.gustafsson@gmail.com>
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
May 30, 2023
This is a re-application of matplotlib#23095, but with some more specific conditions. Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com> Co-authored-by: Oscar Gustafsson <oscar.gustafsson@gmail.com>
devRD
pushed a commit
to devRD/matplotlib
that referenced
this pull request
Jun 5, 2023
This is a re-application of matplotlib#23095, but with some more specific conditions. Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com> Co-authored-by: Oscar Gustafsson <oscar.gustafsson@gmail.com>
melissawm
pushed a commit
to melissawm/matplotlib
that referenced
this pull request
Jun 15, 2023
This is a re-application of matplotlib#23095, but with some more specific conditions. Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com> Co-authored-by: Oscar Gustafsson <oscar.gustafsson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stopgap solution for #23094.
Mid-term we should get the CI environment sorted out to have a working Tk setup. But until then, it's better to xfail than to have all PRs cluttered with these failures.
This is a blind attempt. - CI will decide whether I did everything correctly.