Repository navigation
Fix spacing after mathtext operators with sub/superscripts - #23243
Merged
oscargus merged 1 commit intoJun 12, 2022
Merged
oscargus merged 1 commit into
oscargus merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
anntzer
approved these changes
Jun 11, 2022
oscargus
reviewed
Jun 11, 2022
Comment thread
lib/matplotlib/tests/test_mathtext.py
Outdated
| fig_test.text(0.1, 0.8, r"$\log_2$") | ||
| # Check spacing after Sub/Super scripts | ||
| # Github issue 17852 | ||
| fig_test.text(0.1, 0.7, r"$\sin^2 \cos$") |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Should one position the text elsewhere? Although it may not be the case here, if one continue to reuse coordinates sooner or later there will be a black area...
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Yes, of course.
Sorry, something went wrong.
Picks up matplotlib#22839. Closes matplotlib#22839, matplotlib#17852. Co-authored-by: henrybeUM <98666765+henrybeUM@users.noreply.github.com>
timhoffm
force-pushed
the
take-over-22839
branch
from
0380a24 to
ed4a462
Compare
June 12, 2022 21:17
oscargus
approved these changes
Jun 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up #22839, which did not get author response. - This is #22839 plus adding the two minor comments from there. I don't want to force-push to a foreign branch, so I've opened a separate PR. Happy to close this in case #22839 gets response.
Closes #22839, #17852.
Co-authored-by: henrybeUM 98666765+henrybeUM@users.noreply.github.com